Add UMA stats for the resolution camera is started in.

Add UMA stats for the resolution camera is started in.

BUG=webrtc:6302
Committed: https://crrev.com/9d1315a961bdf13ae6765093872fcb82bf9e5787
Cr-Commit-Position: refs/heads/master@{#15022}

[sakal, 2016-11-07 14:46:52]

Description was changed from

==========
Add UMA stats for the resolution camera is started in.

BUG=webrtc:6302
==========

to

==========
Add UMA stats for the resolution camera is started in.

BUG=webrtc:6302
==========

[sakal, 2016-11-07 14:46:52]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2016-11-07 14:47:12]

PTAL

[magjed_webrtc, 2016-11-10 10:42:19]

https://codereview.webrtc.org/2476313002/diff/1/webrtc/api/android/java/src/o...
File webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java
(right):

https://codereview.webrtc.org/2476313002/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java:25: static
final Size[] COMMON_RESOLUTIONS = new Size[] {
Maybe better to use ArrayList here so we can use List.indexOf in
reportCameraResolution.

https://codereview.webrtc.org/2476313002/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java:45: new
Size(3840, 2160), // 19, UHD
Will it be a problem to add new resolutions at the end here, i.e. will it be a
problem to increase the size of the histogram enum in the future?

https://codereview.webrtc.org/2476313002/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java:265:
histogram.addSample(COMMON_RESOLUTIONS.length);
Add a comment that this is for unknown resolutions. Won't this be a problem when
we increase the resolution list? Then suddenly this value stands for a valid
resolution. Can we use -1 instead? Otherwise we can use 0 and add +1 to the
valid resolutions.

[sakal, 2016-11-10 12:26:40]

https://codereview.webrtc.org/2476313002/diff/1/webrtc/api/android/java/src/o...
File webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java
(right):

https://codereview.webrtc.org/2476313002/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java:25: static
final Size[] COMMON_RESOLUTIONS = new Size[] {
On 2016/11/10 10:42:19, magjed_webrtc wrote:
> Maybe better to use ArrayList here so we can use List.indexOf in
> reportCameraResolution.

Done. I didn't originally use ArrayList because I am not fan of how they are
initialized but I guess it is okay.

https://codereview.webrtc.org/2476313002/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java:45: new
Size(3840, 2160), // 19, UHD
On 2016/11/10 10:42:19, magjed_webrtc wrote:
> Will it be a problem to add new resolutions at the end here, i.e. will it be a
> problem to increase the size of the histogram enum in the future?

Yes, it will be, I changed to the other approach.

https://codereview.webrtc.org/2476313002/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java:265:
histogram.addSample(COMMON_RESOLUTIONS.length);
On 2016/11/10 10:42:19, magjed_webrtc wrote:
> Add a comment that this is for unknown resolutions. Won't this be a problem
when
> we increase the resolution list? Then suddenly this value stands for a valid
> resolution. Can we use -1 instead? Otherwise we can use 0 and add +1 to the
> valid resolutions.

Done.

[magjed_webrtc, 2016-11-10 12:39:30]

lgtm

[sakal, 2016-11-10 13:09:15]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-11-10 13:09:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-10 13:10:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 13:10:36]

Try jobs failed on following builders:
  android_more_configs on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_more_configs/bu...)
  ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/12373)
  ios64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gyp_dbg/builds/2255)
  ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/12389)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/14726)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/14604)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/19958)

[sakal, 2016-11-10 14:06:16]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-11-10 14:06:17]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2476313002/#ps60001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-11-10 14:06:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-10 14:10:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 14:10:16]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/16050)

[sakal, 2016-11-10 14:30:10]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-11-10 14:30:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-10 14:35:19]

Description was changed from

==========
Add UMA stats for the resolution camera is started in.

BUG=webrtc:6302
==========

to

==========
Add UMA stats for the resolution camera is started in.

BUG=webrtc:6302
==========

[commit-bot: I haz the power, 2016-11-10 14:35:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-10 14:35:30]

Description was changed from

==========
Add UMA stats for the resolution camera is started in.

BUG=webrtc:6302
==========

to

==========
Add UMA stats for the resolution camera is started in.

BUG=webrtc:6302

Committed: https://crrev.com/9d1315a961bdf13ae6765093872fcb82bf9e5787
Cr-Commit-Position: refs/heads/master@{#15022}
==========

[commit-bot: I haz the power, 2016-11-10 14:35:31]

Patchset 4 (id:??) landed as
https://crrev.com/9d1315a961bdf13ae6765093872fcb82bf9e5787
Cr-Commit-Position: refs/heads/master@{#15022}