Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1469)

Issue 2476283002: PacketBuffer no longer copy the bitstream data of incoming packets. (Closed)

Created:
4 years, 1 month ago by philipel
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

PacketBuffer no longer copy the bitstream data of incoming packets. This change the interface of the PacketBuffer since the bitstream data of the packet has to be persistent when inserted into the PacketBuffer. BUG=webrtc:5514 R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/41b8ca042065d2f1bec632b80d0e1c1ef8f452fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -36 lines) Patch
M webrtc/modules/video_coding/packet_buffer.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/video_packet_buffer_unittest.cc View 4 chunks +42 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
philipel
4 years, 1 month ago (2016-11-07 12:49:42 UTC) #2
stefan-webrtc
Mention that this changes the packet buffer interface in the description of the CL just ...
4 years, 1 month ago (2016-11-07 12:55:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2476283002/1
4 years, 1 month ago (2016-11-07 12:58:06 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/41b8ca042065d2f1bec632b80d0e1c1ef8f452fc Cr-Commit-Position: refs/heads/master@{#14949}
4 years, 1 month ago (2016-11-07 14:42:35 UTC) #8
philipel
4 years, 1 month ago (2016-11-07 14:42:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
41b8ca042065d2f1bec632b80d0e1c1ef8f452fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698