webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc - Issue 2474993002: Pass selected cricket::VideoCodec down to internal H264 encoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc

Issue 2474993002: Pass selected cricket::VideoCodec down to internal H264 encoder (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc

diff --git a/webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc b/webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc

index d67a43420c45f9746870f3cf3df856def1a921d5..c67775a3acd5ac3de73b537cbe47363cbfe324db 100644

--- a/webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc

+++ b/webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc

@@ -24,6 +24,7 @@ extern "C" {

#include "webrtc/base/criticalsection.h"

#include "webrtc/base/keep_ref_until_done.h"

#include "webrtc/base/logging.h"

+#include "webrtc/modules/video_coding/include/video_codec_interface.h"

hta-webrtc 2016/11/23 14:08:53 Are these includes needed, given no other changes?

magjed_webrtc 2016/11/25 12:09:36 I have just moved it from webrtc/modules/video_cod

magjed_webrtc 2016/11/28 10:20:29 I ended up reverting these unrelated include chang

#include "webrtc/system_wrappers/include/metrics.h"

namespace webrtc {