Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 2474993002: Pass selected cricket::VideoCodec down to internal H264 encoder (Closed)
Patch Set: Fix. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index 492f55d6ec8bf1863a0bb0f903d2f1f40f32d9fe..7559f136e7465b27b109cec7cd668dcf6859fc78 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -354,7 +354,7 @@ class CodecObserver : public test::EndToEndTest,
TEST_F(EndToEndTest, SendsAndReceivesVP8Rotation90) {
CodecObserver test(5, kVideoRotation_90, "VP8",
- VideoEncoder::Create(VideoEncoder::kVp8),
+ VideoEncoder::Create(cricket::VideoCodec("VP8")),
VP8Decoder::Create());
RunBaseTest(&test);
}
@@ -362,14 +362,14 @@ TEST_F(EndToEndTest, SendsAndReceivesVP8Rotation90) {
#if !defined(RTC_DISABLE_VP9)
TEST_F(EndToEndTest, SendsAndReceivesVP9) {
CodecObserver test(500, kVideoRotation_0, "VP9",
- VideoEncoder::Create(VideoEncoder::kVp9),
+ VideoEncoder::Create(cricket::VideoCodec("VP9")),
VP9Decoder::Create());
RunBaseTest(&test);
}
TEST_F(EndToEndTest, SendsAndReceivesVP9VideoRotation90) {
CodecObserver test(5, kVideoRotation_90, "VP9",
- VideoEncoder::Create(VideoEncoder::kVp9),
+ VideoEncoder::Create(cricket::VideoCodec("VP9")),
VP9Decoder::Create());
RunBaseTest(&test);
}
@@ -677,7 +677,7 @@ TEST_F(EndToEndTest, ReceivedUlpfecPacketsNotNacked) {
ulpfec_sequence_number_(0),
has_last_sequence_number_(false),
last_sequence_number_(0),
- encoder_(VideoEncoder::Create(VideoEncoder::EncoderType::kVp8)),
+ encoder_(VideoEncoder::Create(cricket::VideoCodec("VP8"))),
decoder_(VP8Decoder::Create()) {}
private:
@@ -845,7 +845,7 @@ void EndToEndTest::DecodesRetransmittedFrame(bool enable_rtx, bool enable_red) {
retransmission_ssrc_(enable_rtx ? kSendRtxSsrcs[0]
: kVideoSendSsrcs[0]),
retransmission_payload_type_(GetPayloadType(enable_rtx, enable_red)),
- encoder_(VideoEncoder::Create(VideoEncoder::EncoderType::kVp8)),
+ encoder_(VideoEncoder::Create(cricket::VideoCodec("VP8"))),
marker_bits_observed_(0),
retransmitted_timestamp_(0) {}
@@ -1244,7 +1244,7 @@ class MultiStreamTest {
std::unique_ptr<VideoEncoder> encoders[kNumStreams];
for (size_t i = 0; i < kNumStreams; ++i)
- encoders[i].reset(VideoEncoder::Create(VideoEncoder::kVp8));
+ encoders[i].reset(VideoEncoder::Create(cricket::VideoCodec("VP8")));
VideoSendStream* send_streams[kNumStreams];
VideoReceiveStream* receive_streams[kNumStreams];
@@ -2095,7 +2095,7 @@ void EndToEndTest::VerifyHistogramStats(bool use_rtx,
screenshare_(screenshare),
// This test uses NACK, so to send FEC we can't use a fake encoder.
vp8_encoder_(
- use_red ? VideoEncoder::Create(VideoEncoder::EncoderType::kVp8)
+ use_red ? VideoEncoder::Create(cricket::VideoCodec("VP8"))
: nullptr),
sender_call_(nullptr),
receiver_call_(nullptr),
@@ -3873,7 +3873,7 @@ TEST_F(EndToEndLogTest, LogsEncodedFramesWhenRequested) {
VideoSendStream::Config* send_config,
std::vector<VideoReceiveStream::Config>* receive_configs,
VideoEncoderConfig* encoder_config) override {
- encoder_.reset(VideoEncoder::Create(VideoEncoder::kVp8));
+ encoder_.reset(VideoEncoder::Create(cricket::VideoCodec("VP8")));
decoder_.reset(VP8Decoder::Create());
send_config->post_encode_callback = this;

Powered by Google App Engine
This is Rietveld 408576698