Replace Check for too many pending frames in I420_buffer_pool with returning nullptr. Added histogr…

Replace Check for too many pending frames in I420_buffer_pool with returning nullptr. Added histograms for when this happens in VP8Impl.

BUG=chromium:542522
R=tommi@webrtc.org

Committed: https://crrev.com/00983572b0a65e9c9f65e8fc9e0628cb1399aa28
Cr-Commit-Position: refs/heads/master@{#14930}

[perkj_webrtc, 2016-11-03 22:05:29]

Description was changed from

==========
Replace Check for too many pending frames in I420_buffer_pool with returning
nullptr. Added histograms for when this happens in VP8Impl.

BUG=chrome:542522
==========

to

==========
Replace Check for too many pending frames in I420_buffer_pool with returning
nullptr. Added histograms for when this happens in VP8Impl.

BUG=chromium:542522
==========

[perkj_webrtc, 2016-11-03 22:10:37]

perkj@webrtc.org changed reviewers:
+ tommi@webrtc.org

[perkj_webrtc, 2016-11-03 22:10:38]

I manually tested this. Not sure if it is worth writing a video end to end test
that waits until this happen.

[tommi, 2016-11-03 22:48:49]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-11-03 22:48:50]

lgtm

[commit-bot: I haz the power, 2016-11-03 22:48:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-04 01:52:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 01:52:06]

Try jobs failed on following builders:
  win_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/2825)

[commit-bot: I haz the power, 2016-11-04 07:57:46]

Description was changed from

==========
Replace Check for too many pending frames in I420_buffer_pool with returning
nullptr. Added histograms for when this happens in VP8Impl.

BUG=chromium:542522
==========

to

==========
Replace Check for too many pending frames in I420_buffer_pool with returning
nullptr. Added histograms for when this happens in VP8Impl.

BUG=chromium:542522
R=tommi@webrtc.org

Committed: https://crrev.com/00983572b0a65e9c9f65e8fc9e0628cb1399aa28
Cr-Commit-Position: refs/heads/master@{#14930}
==========

[perkj_webrtc, 2016-11-04 07:57:46]

Description was changed from

==========
Replace Check for too many pending frames in I420_buffer_pool with returning
nullptr. Added histograms for when this happens in VP8Impl.

BUG=chromium:542522
R=tommi@webrtc.org

Committed: https://crrev.com/00983572b0a65e9c9f65e8fc9e0628cb1399aa28
Cr-Commit-Position: refs/heads/master@{#14930}
==========

to

==========
Replace Check for too many pending frames in I420_buffer_pool with returning
nullptr. Added histograms for when this happens in VP8Impl.

BUG=chromium:542522
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/00983572b0a65e9c9f65e8fc9...
==========

[commit-bot: I haz the power, 2016-11-04 07:57:47]

Patchset 1 (id:??) landed as
https://crrev.com/00983572b0a65e9c9f65e8fc9e0628cb1399aa28
Cr-Commit-Position: refs/heads/master@{#14930}

[perkj_webrtc, 2016-11-04 07:57:48]

Committed patchset #1 (id:1) manually as
00983572b0a65e9c9f65e8fc9e0628cb1399aa28 (presubmit successful).

[magjed_webrtc, 2016-11-04 08:21:35]

magjed@webrtc.org changed reviewers:
+ magjed@webrtc.org

[magjed_webrtc, 2016-11-04 08:21:36]

https://codereview.webrtc.org/2474783005/diff/1/webrtc/common_video/include/i...
File webrtc/common_video/include/i420_buffer_pool.h (right):

https://codereview.webrtc.org/2474783005/diff/1/webrtc/common_video/include/i...
webrtc/common_video/include/i420_buffer_pool.h:32: : I420BufferPool(false,
std::numeric_limits<size_t>::max()) {}
nit: this is enough: I420BufferPool(false) {}

https://codereview.webrtc.org/2474783005/diff/1/webrtc/common_video/include/i...
webrtc/common_video/include/i420_buffer_pool.h:59: size_t
max_number_of_buffers_;
It would be nice to have this (and zero_initialize_) const.

[perkj_webrtc, 2016-11-04 12:04:27]

On 2016/11/04 08:21:36, magjed_webrtc wrote:
>
https://codereview.webrtc.org/2474783005/diff/1/webrtc/common_video/include/i...
> File webrtc/common_video/include/i420_buffer_pool.h (right):
> 
>
https://codereview.webrtc.org/2474783005/diff/1/webrtc/common_video/include/i...
> webrtc/common_video/include/i420_buffer_pool.h:32: : I420BufferPool(false,
> std::numeric_limits<size_t>::max()) {}
> nit: this is enough: I420BufferPool(false) {}
> 
>
https://codereview.webrtc.org/2474783005/diff/1/webrtc/common_video/include/i...
> webrtc/common_video/include/i420_buffer_pool.h:59: size_t
> max_number_of_buffers_;
> It would be nice to have this (and zero_initialize_) const.

Fixed in follow up https://codereview.webrtc.org/2473383002/.