Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 2474433012: Refactor WebRtcVideoReceiveStream::FilterSupportedCodecs (Closed)

Created:
4 years, 1 month ago by magjed_webrtc
Modified:
4 years, 1 month ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Refactor WebRtcVideoReceiveStream::FilterSupportedCodecs This CL removes WebRtcVideoReceiveStream::FilterSupportedCodecs and adds more fine grained code for selecting and verifying codecs. This also removes unnecessary copying of cricket::VideoCodecs. BUG=webrtc:6337 Committed: https://crrev.com/23b7a4a3906dbe9edc3b2188198a1a2c24be3154 Cr-Commit-Position: refs/heads/master@{#14964}

Patch Set 1 : Simplify and remove comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -32 lines) Patch
M webrtc/media/engine/webrtcvideoengine2.h View 2 chunks +6 lines, -3 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 6 chunks +29 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
magjed_webrtc
Kàri - please take a look.
4 years, 1 month ago (2016-11-07 14:30:58 UTC) #7
kthelgason
lgtm
4 years, 1 month ago (2016-11-07 16:28:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2474433012/40001
4 years, 1 month ago (2016-11-08 09:00:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 1 month ago (2016-11-08 09:12:57 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 09:13:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23b7a4a3906dbe9edc3b2188198a1a2c24be3154
Cr-Commit-Position: refs/heads/master@{#14964}

Powered by Google App Engine
This is Rietveld 408576698