Add bitrate section to settings view controller.

Add bitrate section to settings view controller.

BUG=webrtc:6654
Committed: https://crrev.com/3babb99039478c36be58171c5409eac07ae153e5
Cr-Commit-Position: refs/heads/master@{#14952}

[daniela-webrtc, 2016-11-03 14:37:12]

denicija@webrtc.org changed reviewers:
+ kthelgasson@webrtc.org, magjed@webrtc.org

[magjed_webrtc, 2016-11-03 15:06:25]

Description was changed from

==========
Add bitrate section to settings view controller.

BUG=6654
==========

to

==========
Add bitrate section to settings view controller.

BUG=webrtc:6654
==========

[magjed_webrtc, 2016-11-03 21:17:31]

https://codereview.webrtc.org/2473783003/diff/1/webrtc/examples/objc/AppRTCMo...
File webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsViewController.m (right):

https://codereview.webrtc.org/2473783003/diff/1/webrtc/examples/objc/AppRTCMo...
webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsViewController.m:202:
initWithFrame:CGRectMake(10, 0, cell.bounds.size.width - 20,
cell.bounds.size.height)];
What do the constants 10 and -20 represent here?

https://codereview.webrtc.org/2473783003/diff/1/webrtc/examples/objc/AppRTCMo...
webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsViewController.m:206: //
Numerical keyboards have no return button, we need to add one manually.
Wow, much boilerplate.

[magjed_webrtc, 2016-11-07 10:08:57]

lgtm

[daniela-webrtc, 2016-11-07 12:58:01]

The CQ bit was checked by denicija@webrtc.org

[commit-bot: I haz the power, 2016-11-07 12:58:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-07 15:23:57]

Description was changed from

==========
Add bitrate section to settings view controller.

BUG=webrtc:6654
==========

to

==========
Add bitrate section to settings view controller.

BUG=webrtc:6654
==========

[commit-bot: I haz the power, 2016-11-07 15:23:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-07 15:24:06]

Description was changed from

==========
Add bitrate section to settings view controller.

BUG=webrtc:6654
==========

to

==========
Add bitrate section to settings view controller.

BUG=webrtc:6654

Committed: https://crrev.com/3babb99039478c36be58171c5409eac07ae153e5
Cr-Commit-Position: refs/heads/master@{#14952}
==========

[commit-bot: I haz the power, 2016-11-07 15:24:07]

Patchset 1 (id:??) landed as
https://crrev.com/3babb99039478c36be58171c5409eac07ae153e5
Cr-Commit-Position: refs/heads/master@{#14952}

[daniela-webrtc, 2016-11-08 12:00:43]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2488653002/ by denicija@webrtc.org.

The reason for reverting is: The usage of UIKeyboardTypeASCIICapableNumberPad
enum (available only for iOS 10.0), is breaking the build of AppRTCMobile on
devices with lesser os.
To re-land the UIKeyboardTypeASCIICapableNumberPad should be replaced with
UIKeyboardTypeNumberPad
.

[daniela-webrtc, 2016-11-08 13:04:21]

Description was changed from

==========
Add bitrate section to settings view controller.

BUG=webrtc:6654

Committed: https://crrev.com/3babb99039478c36be58171c5409eac07ae153e5
Cr-Commit-Position: refs/heads/master@{#14952}
==========

to

==========
Add bitrate section to settings view controller.

BUG=webrtc:6654

Committed: https://crrev.com/3babb99039478c36be58171c5409eac07ae153e5
Cr-Commit-Position: refs/heads/master@{#14952}
==========

[daniela-webrtc, 2016-11-08 13:05:54]

Need to re-land this one as it broke AppRTCMobile on some devices (using enum
that is available only for certain iOS versions).
Mind taking another look?

[magjed_webrtc, 2016-11-09 08:57:08]

On 2016/11/08 13:05:54, denicija-webrtc wrote:
> Need to re-land this one as it broke AppRTCMobile on some devices (using enum
> that is available only for certain iOS versions).
> Mind taking another look?

The best way to re-land is to press the "Revert Patchset" button on the revert
CL and make sure to unpress 'Automatically send Revert CL to CQ'. The CL
description will be set to "Reland of ..." and filled in automatically in a nice
way. Then you upload a new patchset to the reland CL with the fix (so the patch
sets will look exactly like this CL).

You can checkout a CL with 'git cl patch <number>' where <number> is 2473783003
for example. Or you can attach an existing branch to a CL with 'git cl issue
<number>'.