Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: webrtc/api/peerconnection_unittest.cc

Issue 2473603002: Fix the issue of setting local description with datachannel only and max-bundle. (Closed)
Patch Set: Fix the issues when setting local description with datachannel only Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/peerconnection.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnection_unittest.cc
diff --git a/webrtc/api/peerconnection_unittest.cc b/webrtc/api/peerconnection_unittest.cc
index 981cec778a690108de0b21850e4c3328a035cabe..5d4a14d67373b045bf22771b812e29db663cee12 100644
--- a/webrtc/api/peerconnection_unittest.cc
+++ b/webrtc/api/peerconnection_unittest.cc
@@ -1762,6 +1762,18 @@ TEST_F(P2PTestConductor, LocalP2PTestOfferDtlsButNotSdes) {
VerifyRenderedSize(640, 480);
}
+// This test verifies that the negotiation will success with data channel only
Taylor Brandstetter 2016/11/02 23:10:22 "will success" -> "will succeed"
+// in max-bundle mode.
+TEST_F(P2PTestConductor, LocalP2PTestOfferDataChannelOnly) {
+ webrtc::PeerConnectionInterface::RTCConfiguration rtc_config;
+ rtc_config.bundle_policy =
+ webrtc::PeerConnectionInterface::kBundlePolicyMaxBundle;
+ ASSERT_TRUE(CreateTestClients(rtc_config, rtc_config));
+ initializing_client()->CreateDataChannel();
+ initializing_client()->AddMediaStream(false /*No audio*/, false /*No video*/);
Taylor Brandstetter 2016/11/02 23:10:22 Just curious, why is adding a media stream necessa
+ initializing_client()->Negotiate();
+}
+
// This test sets up a Jsep call between two parties, and the callee only
// accept to receive video.
TEST_F(P2PTestConductor, LocalP2PTestAnswerVideo) {
« no previous file with comments | « webrtc/api/peerconnection.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698