Fix the issue of setting local description with datachannel only and max-bundle.

Make SetLocalDescrption succeed with data-channel only offer and max-bundle policy.

This CL sets the data channel type of the session options before setting the bundle-enabled flag of the session options, so that bundle-enabled will be correctly set and the bundle group will be created.

BUG=webrtc:6218
Committed: https://crrev.com/af38847c02d6542d6125658566cd4af3b0fe4276
Cr-Commit-Position: refs/heads/master@{#14904}

[Zhi Huang, 2016-11-02 19:06:43]

Patchset #1 (id:1) has been deleted

[Zhi Huang, 2016-11-02 19:10:22]

Description was changed from

==========
Make the SetLocalDescrption success with data-channel only offer and max-bundle
policy.

Setting the data channel type of the session options before setting the
bundle-enabled flag of the session options so that bundle-enabled can be
correctly set and the bundle group will be created.

BUG=webrtc:6218
==========

to

==========
Make the SetLocalDescrption success with data-channel only offer and max-bundle
policy.

Setting the data channel type of the session options before setting the
bundle-enabled flag of the session options so that bundle-enabled can be
correctly set and the bundle group will be created.

BUG=webrtc:6218
==========

[Taylor Brandstetter, 2016-11-02 23:08:04]

Description was changed from

==========
Make the SetLocalDescrption success with data-channel only offer and max-bundle
policy.

Setting the data channel type of the session options before setting the
bundle-enabled flag of the session options so that bundle-enabled can be
correctly set and the bundle group will be created.

BUG=webrtc:6218
==========

to

==========
Make SetLocalDescrption succeed with data-channel only offer and max-bundle
policy.

This CL sets the data channel type of the session options before setting the
bundle-enabled flag of the session options, so that bundle-enabled will be
correctly set and the bundle group will be created.

BUG=webrtc:6218
==========

[Taylor Brandstetter, 2016-11-02 23:10:22]

deadbeef@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2016-11-02 23:10:22]

lgtm

https://codereview.webrtc.org/2473603002/diff/20001/webrtc/api/peerconnection...
File webrtc/api/peerconnection_unittest.cc (right):

https://codereview.webrtc.org/2473603002/diff/20001/webrtc/api/peerconnection...
webrtc/api/peerconnection_unittest.cc:1765: // This test verifies that the
negotiation will success with data channel only
"will success" -> "will succeed"

https://codereview.webrtc.org/2473603002/diff/20001/webrtc/api/peerconnection...
webrtc/api/peerconnection_unittest.cc:1773:
initializing_client()->AddMediaStream(false /*No audio*/, false /*No video*/);
Just curious, why is adding a media stream necessary? Is it due to the weird
test infrastructure? May be worth leaving a comment explaining.

[Zhi Huang, 2016-11-02 23:26:02]

The CQ bit was checked by zhihuang@webrtc.org

[Zhi Huang, 2016-11-02 23:26:03]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2473603002/#ps40001 (title:
"minor fix")

[commit-bot: I haz the power, 2016-11-02 23:26:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-02 23:49:51]

Description was changed from

==========
Make SetLocalDescrption succeed with data-channel only offer and max-bundle
policy.

This CL sets the data channel type of the session options before setting the
bundle-enabled flag of the session options, so that bundle-enabled will be
correctly set and the bundle group will be created.

BUG=webrtc:6218
==========

to

==========
Make SetLocalDescrption succeed with data-channel only offer and max-bundle
policy.

This CL sets the data channel type of the session options before setting the
bundle-enabled flag of the session options, so that bundle-enabled will be
correctly set and the bundle group will be created.

BUG=webrtc:6218
==========

[commit-bot: I haz the power, 2016-11-02 23:49:52]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-02 23:50:02]

Description was changed from

==========
Make SetLocalDescrption succeed with data-channel only offer and max-bundle
policy.

This CL sets the data channel type of the session options before setting the
bundle-enabled flag of the session options, so that bundle-enabled will be
correctly set and the bundle group will be created.

BUG=webrtc:6218
==========

to

==========
Make SetLocalDescrption succeed with data-channel only offer and max-bundle
policy.

This CL sets the data channel type of the session options before setting the
bundle-enabled flag of the session options, so that bundle-enabled will be
correctly set and the bundle group will be created.

BUG=webrtc:6218

Committed: https://crrev.com/af38847c02d6542d6125658566cd4af3b0fe4276
Cr-Commit-Position: refs/heads/master@{#14904}
==========

[commit-bot: I haz the power, 2016-11-02 23:50:02]

Patchset 2 (id:??) landed as
https://crrev.com/af38847c02d6542d6125658566cd4af3b0fe4276
Cr-Commit-Position: refs/heads/master@{#14904}