Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: webrtc/common_video/include/i420_buffer_pool.h

Issue 2473383002: Changed I420BufferPool members to be const. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 11 matching lines...) Expand all
22 // Simple buffer pool to avoid unnecessary allocations of I420Buffer objects. 22 // Simple buffer pool to avoid unnecessary allocations of I420Buffer objects.
23 // The pool manages the memory of the I420Buffer returned from CreateBuffer. 23 // The pool manages the memory of the I420Buffer returned from CreateBuffer.
24 // When the I420Buffer is destructed, the memory is returned to the pool for use 24 // When the I420Buffer is destructed, the memory is returned to the pool for use
25 // by subsequent calls to CreateBuffer. If the resolution passed to CreateBuffer 25 // by subsequent calls to CreateBuffer. If the resolution passed to CreateBuffer
26 // changes, old buffers will be purged from the pool. 26 // changes, old buffers will be purged from the pool.
27 // Note that CreateBuffer will crash if more than kMaxNumberOfFramesBeforeCrash 27 // Note that CreateBuffer will crash if more than kMaxNumberOfFramesBeforeCrash
28 // are created. This is to prevent memory leaks where frames are not returned. 28 // are created. This is to prevent memory leaks where frames are not returned.
29 class I420BufferPool { 29 class I420BufferPool {
30 public: 30 public:
31 I420BufferPool() 31 I420BufferPool()
32 : I420BufferPool(false, std::numeric_limits<size_t>::max()) {} 32 : I420BufferPool(false) {}
33 explicit I420BufferPool(bool zero_initialize) 33 explicit I420BufferPool(bool zero_initialize)
34 : I420BufferPool(zero_initialize, std::numeric_limits<size_t>::max()) {} 34 : I420BufferPool(zero_initialize, std::numeric_limits<size_t>::max()) {}
35 I420BufferPool(bool zero_initialze, size_t max_number_of_buffers); 35 I420BufferPool(bool zero_initialze, size_t max_number_of_buffers);
36 36
37 // Returns a buffer from the pool. If no suitable buffer exist in the pool 37 // Returns a buffer from the pool. If no suitable buffer exist in the pool
38 // and there are less than |max_number_of_buffers| pending, a buffer is 38 // and there are less than |max_number_of_buffers| pending, a buffer is
39 // created. Returns null otherwise. 39 // created. Returns null otherwise.
40 rtc::scoped_refptr<I420Buffer> CreateBuffer(int width, int height); 40 rtc::scoped_refptr<I420Buffer> CreateBuffer(int width, int height);
41 // Clears buffers_ and detaches the thread checker so that it can be reused 41 // Clears buffers_ and detaches the thread checker so that it can be reused
42 // later from another thread. 42 // later from another thread.
43 void Release(); 43 void Release();
44 44
45 private: 45 private:
46 // Explicitly use a RefCountedObject to get access to HasOneRef, 46 // Explicitly use a RefCountedObject to get access to HasOneRef,
47 // needed by the pool to check exclusive access. 47 // needed by the pool to check exclusive access.
48 using PooledI420Buffer = rtc::RefCountedObject<I420Buffer>; 48 using PooledI420Buffer = rtc::RefCountedObject<I420Buffer>;
49 49
50 rtc::RaceChecker race_checker_; 50 rtc::RaceChecker race_checker_;
51 std::list<rtc::scoped_refptr<PooledI420Buffer>> buffers_; 51 std::list<rtc::scoped_refptr<PooledI420Buffer>> buffers_;
52 // If true, newly allocated buffers are zero-initialized. Note that recycled 52 // If true, newly allocated buffers are zero-initialized. Note that recycled
53 // buffers are not zero'd before reuse. This is required of buffers used by 53 // buffers are not zero'd before reuse. This is required of buffers used by
54 // FFmpeg according to http://crbug.com/390941, which only requires it for the 54 // FFmpeg according to http://crbug.com/390941, which only requires it for the
55 // initial allocation (as shown by FFmpeg's own buffer allocation code). It 55 // initial allocation (as shown by FFmpeg's own buffer allocation code). It
56 // has to do with "Use-of-uninitialized-value" on "Linux_msan_chrome". 56 // has to do with "Use-of-uninitialized-value" on "Linux_msan_chrome".
57 bool zero_initialize_; 57 const bool zero_initialize_;
58 // Max number of buffers this pool can have pending. 58 // Max number of buffers this pool can have pending.
59 size_t max_number_of_buffers_; 59 const size_t max_number_of_buffers_;
60 }; 60 };
61 61
62 } // namespace webrtc 62 } // namespace webrtc
63 63
64 #endif // WEBRTC_COMMON_VIDEO_INCLUDE_I420_BUFFER_POOL_H_ 64 #endif // WEBRTC_COMMON_VIDEO_INCLUDE_I420_BUFFER_POOL_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698