Chromium Code Reviews

Issue 2472673002: Revert of Remove webrtc::Video from H264 encoder internals (Closed)

Created:
4 years, 1 month ago by hta-webrtc
Modified:
4 years, 1 month ago
Reviewers:
magjed_webrtc, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove webrtc::Video from H264 encoder internals (patchset #2 id:20001 of https://codereview.webrtc.org/2468903003/ ) Reason for revert: Landed the wrong patchset. Nothing broken. Original issue's description: > Remove webrtc::Video from H264 encoder internals > > This CL replaces the use of webrtc::Video as an internal > variable in the H.264 encoder with the specific fields > that are used by this encoder. > > In support of refactorings discussed around: > > BUG=600254 > > Committed: https://crrev.com/2549437b5ccf5aae2e6f1a1491c5f505d1859f9c > Cr-Commit-Position: refs/heads/master@{#14887} TBR=magjed@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600254 Committed: https://crrev.com/6ad7fa4606643d382ee7cf91aa90597c2af8cfa4 Cr-Commit-Position: refs/heads/master@{#14888}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+35 lines, -49 lines)
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h View 1 chunk +1 line, -11 lines 0 comments
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 5 chunks +34 lines, -38 lines 0 comments

Messages

Total messages: 6 (2 generated)
hta-webrtc
Created Revert of Remove webrtc::Video from H264 encoder internals
4 years, 1 month ago (2016-11-02 13:53:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2472673002/1
4 years, 1 month ago (2016-11-02 13:53:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 13:53:22 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 13:53:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ad7fa4606643d382ee7cf91aa90597c2af8cfa4
Cr-Commit-Position: refs/heads/master@{#14888}

Powered by Google App Engine