Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: webrtc/api/peerconnection.h

Issue 2472113002: Correct stats for RTCPeerConnectionStats.dataChannels[Opened/Closed]. (Closed)
Patch Set: Addressed deadbeef's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/datachannel_unittest.cc ('k') | webrtc/api/peerconnection.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 const std::vector<cricket::Candidate>& candidates) override; 136 const std::vector<cricket::Candidate>& candidates) override;
137 137
138 void RegisterUMAObserver(UMAObserver* observer) override; 138 void RegisterUMAObserver(UMAObserver* observer) override;
139 139
140 bool StartRtcEventLog(rtc::PlatformFile file, 140 bool StartRtcEventLog(rtc::PlatformFile file,
141 int64_t max_size_bytes) override; 141 int64_t max_size_bytes) override;
142 void StopRtcEventLog() override; 142 void StopRtcEventLog() override;
143 143
144 void Close() override; 144 void Close() override;
145 145
146 sigslot::signal1<DataChannel*> SignalDataChannelCreated;
147
146 // Virtual for unit tests. 148 // Virtual for unit tests.
147 virtual const std::vector<rtc::scoped_refptr<DataChannel>>& 149 virtual const std::vector<rtc::scoped_refptr<DataChannel>>&
148 sctp_data_channels() const { 150 sctp_data_channels() const {
149 return sctp_data_channels_; 151 return sctp_data_channels_;
150 } 152 }
151 153
152 protected: 154 protected:
153 ~PeerConnection() override; 155 ~PeerConnection() override;
154 156
155 private: 157 private:
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 rtc::scoped_refptr<RtpReceiverProxyWithInternal<RtpReceiverInternal>>> 428 rtc::scoped_refptr<RtpReceiverProxyWithInternal<RtpReceiverInternal>>>
427 receivers_; 429 receivers_;
428 std::unique_ptr<WebRtcSession> session_; 430 std::unique_ptr<WebRtcSession> session_;
429 std::unique_ptr<StatsCollector> stats_; 431 std::unique_ptr<StatsCollector> stats_;
430 rtc::scoped_refptr<RTCStatsCollector> stats_collector_; 432 rtc::scoped_refptr<RTCStatsCollector> stats_collector_;
431 }; 433 };
432 434
433 } // namespace webrtc 435 } // namespace webrtc
434 436
435 #endif // WEBRTC_API_PEERCONNECTION_H_ 437 #endif // WEBRTC_API_PEERCONNECTION_H_
OLDNEW
« no previous file with comments | « webrtc/api/datachannel_unittest.cc ('k') | webrtc/api/peerconnection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698