NetEq: Don't forget to save the codec name

NetEq: Don't forget to save the codec name

BUG=chromium:661362
Committed: https://crrev.com/e941306bd66883266bc0e51baefad6ab25142fd6
Cr-Commit-Position: refs/heads/master@{#14909}

[kwiberg-webrtc, 2016-11-03 11:48:52]

kwiberg@webrtc.org changed reviewers:
+ ossu@webrtc.org

[kwiberg-webrtc, 2016-11-03 11:49:12]

Description was changed from

==========
NetEq: Don't forget to set the codec name

BUG=chromium:661362
==========

to

==========
NetEq: Don't forget to save the codec name

BUG=chromium:661362
==========

[ossu, 2016-11-03 11:56:59]

It might be the cold messing with my head, but I fail to see the functional
change in this CL. As far as I can see, it moves name initialization into the
constructor, but both call sites already fill it in. Not that there's anything
wrong with that, but does it address the bug?

[kwiberg-webrtc, 2016-11-03 12:02:59]

https://codereview.webrtc.org/2472083002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/decoder_database.cc (right):

https://codereview.webrtc.org/2472083002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/decoder_database.cc:41: :
DecoderInfo(audio_format, factory, audio_format.name) {}
The functional change is here; we actually fill in name_ using the value in
audio_format.name.

[ossu, 2016-11-03 12:15:24]

lgtm

https://codereview.webrtc.org/2472083002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/decoder_database.cc (right):

https://codereview.webrtc.org/2472083002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/decoder_database.cc:159: rtp_payload_type,
DecoderInfo(audio_format, decoder_factory_.get())));
Oh, right, this should've had to be done manually here before.

[kwiberg-webrtc, 2016-11-03 12:19:51]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-11-03 12:19:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-03 12:29:07]

Description was changed from

==========
NetEq: Don't forget to save the codec name

BUG=chromium:661362
==========

to

==========
NetEq: Don't forget to save the codec name

BUG=chromium:661362
==========

[commit-bot: I haz the power, 2016-11-03 12:29:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 12:29:16]

Description was changed from

==========
NetEq: Don't forget to save the codec name

BUG=chromium:661362
==========

to

==========
NetEq: Don't forget to save the codec name

BUG=chromium:661362

Committed: https://crrev.com/e941306bd66883266bc0e51baefad6ab25142fd6
Cr-Commit-Position: refs/heads/master@{#14909}
==========

[commit-bot: I haz the power, 2016-11-03 12:29:17]

Patchset 1 (id:??) landed as
https://crrev.com/e941306bd66883266bc0e51baefad6ab25142fd6
Cr-Commit-Position: refs/heads/master@{#14909}