Chromium Code Reviews

Issue 2471073003: Make FlexfecReceiver a concrete class. (Closed)

Created:
4 years, 1 month ago by brandtr
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make FlexfecReceiver a concrete class. There is no need for it to be an interface. In this CL, I also took the opportunity to make two small fixes: - remove the 'flexfec_' prefix from some member variables - remove unnecessary use of a stringstream object BUG=webrtc:5654 Committed: https://crrev.com/0a4c1616bf40a3c33aac46e50c6f9ac79a15ca1b Cr-Commit-Position: refs/heads/master@{#14919}

Patch Set 1 #

Patch Set 2 : Update fuzzer. #

Unified diffs Side-by-side diffs Stats (+110 lines, -341 lines)
M webrtc/call/flexfec_receive_stream.cc View 1 chunk +3 lines, -3 lines 0 comments
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments
M webrtc/modules/rtp_rtcp/include/flexfec_receiver.h View 2 chunks +32 lines, -8 lines 0 comments
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 chunk +1 line, -2 lines 0 comments
A + webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc View 7 chunks +15 lines, -27 lines 0 comments
D webrtc/modules/rtp_rtcp/source/flexfec_receiver_impl.h View 1 chunk +0 lines, -60 lines 0 comments
D webrtc/modules/rtp_rtcp/source/flexfec_receiver_impl.cc View 1 chunk +0 lines, -178 lines 0 comments
M webrtc/modules/rtp_rtcp/source/flexfec_receiver_unittest.cc View 26 chunks +56 lines, -58 lines 0 comments
M webrtc/test/fuzzers/flexfec_receiver_fuzzer.cc View 2 chunks +2 lines, -3 lines 0 comments

Messages

Total messages: 9 (4 generated)
brandtr
Remove interface from FlexfecReceiver as well.
4 years, 1 month ago (2016-11-02 16:07:31 UTC) #2
stefan-webrtc
lgtm
4 years, 1 month ago (2016-11-03 13:38:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2471073003/20001
4 years, 1 month ago (2016-11-03 14:38:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 15:18:30 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 15:40:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a4c1616bf40a3c33aac46e50c6f9ac79a15ca1b
Cr-Commit-Position: refs/heads/master@{#14919}

Powered by Google App Engine