Moved transport_adapter.h/.cc from call/ to video/ dir to remove circular dependency

Moved transport_adapter.h/.cc from call/ to video/ dir to remove circular dependency

Issue: video_receive_stream.cc includes transport_adapter.h which use to be inside call/ and call depends on video/ which caused circular dependency. We moved transport_adapter.h/.cc inside video/ and removed dependency of video/ on call/

BUG=webrtc:6412
NOTRY=True

Committed: https://crrev.com/bf6a45b44253988b8dceda43aad157f340aa6e82
Cr-Commit-Position: refs/heads/master@{#14907}

[charujain, 2016-11-02 16:42:42]

Description was changed from

==========
Moved transport_adapter.h/.cc from call/ to video/ dir to remove circular
dependency

BUG=
==========

to

==========
Moved transport_adapter.h/.cc from call/ to video/ dir to remove circular
dependency

Issue: video_receive_stream.cc includes transport_adapter.h which use to be
inside call/ and call depends on video/ which caused circular dependency. We
moved transport_adapter.h/.cc inside video/ and removed dependency of video/ on
call/

BUG=6412
==========

[charujain, 2016-11-02 16:42:42]

charujain@webrtc.org changed reviewers:
+ holmer@webrtc.org, kjellander@webrtc.org, phoglund@webrtc.org

[charujain, 2016-11-02 16:43:09]

Description was changed from

==========
Moved transport_adapter.h/.cc from call/ to video/ dir to remove circular
dependency

Issue: video_receive_stream.cc includes transport_adapter.h which use to be
inside call/ and call depends on video/ which caused circular dependency. We
moved transport_adapter.h/.cc inside video/ and removed dependency of video/ on
call/

BUG=6412
==========

to

==========
Moved transport_adapter.h/.cc from call/ to video/ dir to remove circular
dependency

Issue: video_receive_stream.cc includes transport_adapter.h which use to be
inside call/ and call depends on video/ which caused circular dependency. We
moved transport_adapter.h/.cc inside video/ and removed dependency of video/ on
call/

BUG=6412
NOTRY=True
==========

[kjellander_webrtc, 2016-11-02 20:28:04]

Description was changed from

==========
Moved transport_adapter.h/.cc from call/ to video/ dir to remove circular
dependency

Issue: video_receive_stream.cc includes transport_adapter.h which use to be
inside call/ and call depends on video/ which caused circular dependency. We
moved transport_adapter.h/.cc inside video/ and removed dependency of video/ on
call/

BUG=6412
NOTRY=True
==========

to

==========
Moved transport_adapter.h/.cc from call/ to video/ dir to remove circular
dependency

Issue: video_receive_stream.cc includes transport_adapter.h which use to be
inside call/ and call depends on video/ which caused circular dependency. We
moved transport_adapter.h/.cc inside video/ and removed dependency of video/ on
call/

BUG=webrtc:6412
NOTRY=True
==========

[kjellander_webrtc, 2016-11-02 20:33:09]

I'm glad you found a solution for this. A few comments.

https://codereview.webrtc.org/2470913004/diff/1/webrtc/call/call_perf_tests.cc
File webrtc/call/call_perf_tests.cc (right):

https://codereview.webrtc.org/2470913004/diff/1/webrtc/call/call_perf_tests.c...
webrtc/call/call_perf_tests.cc:20: #include "webrtc/video/transport_adapter.h"
sort

https://codereview.webrtc.org/2470913004/diff/1/webrtc/call/webrtc_call.gypi
File webrtc/call/webrtc_call.gypi (right):

https://codereview.webrtc.org/2470913004/diff/1/webrtc/call/webrtc_call.gypi#...
webrtc/call/webrtc_call.gypi:22: '../video/transport_adapter.cc',
I'm worried a presubmit check will yell at you about referencing sources above
the current directory, but in this case it's included in webrtc/webrtc.gyp so it
shouldn't be a problem.
https://cs.chromium.org/chromium/src/third_party/webrtc/webrtc.gyp?rcl=0&l=12

If you get a presubmit error because of this, we can discuss removing that one
for GYP since it's so close to be deleted anyway.

https://codereview.webrtc.org/2470913004/diff/1/webrtc/video/transport_adapter.h
File webrtc/video/transport_adapter.h (right):

https://codereview.webrtc.org/2470913004/diff/1/webrtc/video/transport_adapte...
webrtc/video/transport_adapter.h:10: #ifndef WEBRTC_CALL_TRANSPORT_ADAPTER_H_
presubmit should fail if the header guard is not correct

https://codereview.webrtc.org/2470913004/diff/1/webrtc/video/video_receive_st...
File webrtc/video/video_receive_stream.h (right):

https://codereview.webrtc.org/2470913004/diff/1/webrtc/video/video_receive_st...
webrtc/video/video_receive_stream.h:18: #include
"webrtc/video/transport_adapter.h"
sort alphabetically.

https://codereview.webrtc.org/2470913004/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream_tests.cc (right):

https://codereview.webrtc.org/2470913004/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream_tests.cc:22: #include
"webrtc/video/transport_adapter.h"
sort.

[charujain, 2016-11-03 09:12:00]

Fixed the comments.

[stefan-webrtc, 2016-11-03 09:30:28]

stefan@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-11-03 09:30:29]

https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/end_to_end_t...
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:24: #include "webrtc/video/transport_adapter.h"
Sort

https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/transport_ad...
File webrtc/video/transport_adapter.cc (right):

https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/transport_ad...
webrtc/video/transport_adapter.cc:12: #include
"webrtc/video/transport_adapter.h"
Should be the first include here, as it was.

https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/video_receiv...
File webrtc/video/video_receive_stream.cc (right):

https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/video_receiv...
webrtc/video/video_receive_stream.cc:29: #include
"webrtc/video/video_receive_stream.h"
Move back to the top.

https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/video_send_s...
File webrtc/video/video_send_stream_tests.cc (right):

https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/video_send_s...
webrtc/video/video_send_stream_tests.cc:22: #include
"webrtc/video/transport_adapter.h"
sort

[charujain, 2016-11-03 09:51:21]

On 2016/11/03 09:30:29, stefan-webrtc (holmer) wrote:
>
https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/end_to_end_t...
> File webrtc/video/end_to_end_tests.cc (right):
> 
>
https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/end_to_end_t...
> webrtc/video/end_to_end_tests.cc:24: #include
"webrtc/video/transport_adapter.h"
> Sort
> 
>
https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/transport_ad...
> File webrtc/video/transport_adapter.cc (right):
> 
>
https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/transport_ad...
> webrtc/video/transport_adapter.cc:12: #include
> "webrtc/video/transport_adapter.h"
> Should be the first include here, as it was.
> 
>
https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/video_receiv...
> File webrtc/video/video_receive_stream.cc (right):
> 
>
https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/video_receiv...
> webrtc/video/video_receive_stream.cc:29: #include
> "webrtc/video/video_receive_stream.h"
> Move back to the top.
> 
>
https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/video_send_s...
> File webrtc/video/video_send_stream_tests.cc (right):
> 
>
https://codereview.webrtc.org/2470913004/diff/40001/webrtc/video/video_send_s...
> webrtc/video/video_send_stream_tests.cc:22: #include
> "webrtc/video/transport_adapter.h"
> sort

Addressed

[kjellander_webrtc, 2016-11-03 10:02:47]

lgtm, assuming you run at least a few sanity check compile trybots again after
the sortings

[stefan-webrtc, 2016-11-03 10:25:52]

lgtm

[charujain, 2016-11-03 10:32:11]

The CQ bit was checked by charujain@webrtc.org

[commit-bot: I haz the power, 2016-11-03 10:32:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-03 10:35:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 10:35:11]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9780)

[kjellander_webrtc, 2016-11-03 10:46:19]

One cpplint error left

https://codereview.webrtc.org/2470913004/diff/60001/webrtc/video/transport_ad...
File webrtc/video/transport_adapter.h (right):

https://codereview.webrtc.org/2470913004/diff/60001/webrtc/video/transport_ad...
webrtc/video/transport_adapter.h:39: #endif  // WEBRTC_CALL_TRANSPORT_ADAPTER_H_
You missed this one.

[charujain, 2016-11-03 11:20:04]

The CQ bit was checked by charujain@webrtc.org

[charujain, 2016-11-03 11:20:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2470913004/#ps80001 (title:
"Fixed footer guards")

[commit-bot: I haz the power, 2016-11-03 11:20:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-03 11:21:45]

Description was changed from

==========
Moved transport_adapter.h/.cc from call/ to video/ dir to remove circular
dependency

Issue: video_receive_stream.cc includes transport_adapter.h which use to be
inside call/ and call depends on video/ which caused circular dependency. We
moved transport_adapter.h/.cc inside video/ and removed dependency of video/ on
call/

BUG=webrtc:6412
NOTRY=True
==========

to

==========
Moved transport_adapter.h/.cc from call/ to video/ dir to remove circular
dependency

Issue: video_receive_stream.cc includes transport_adapter.h which use to be
inside call/ and call depends on video/ which caused circular dependency. We
moved transport_adapter.h/.cc inside video/ and removed dependency of video/ on
call/

BUG=webrtc:6412
NOTRY=True
==========

[commit-bot: I haz the power, 2016-11-03 11:21:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-03 11:21:49]

Description was changed from

==========
Moved transport_adapter.h/.cc from call/ to video/ dir to remove circular
dependency

Issue: video_receive_stream.cc includes transport_adapter.h which use to be
inside call/ and call depends on video/ which caused circular dependency. We
moved transport_adapter.h/.cc inside video/ and removed dependency of video/ on
call/

BUG=webrtc:6412
NOTRY=True
==========

to

==========
Moved transport_adapter.h/.cc from call/ to video/ dir to remove circular
dependency

Issue: video_receive_stream.cc includes transport_adapter.h which use to be
inside call/ and call depends on video/ which caused circular dependency. We
moved transport_adapter.h/.cc inside video/ and removed dependency of video/ on
call/

BUG=webrtc:6412
NOTRY=True

Committed: https://crrev.com/bf6a45b44253988b8dceda43aad157f340aa6e82
Cr-Commit-Position: refs/heads/master@{#14907}
==========

[commit-bot: I haz the power, 2016-11-03 11:21:51]

Patchset 5 (id:??) landed as
https://crrev.com/bf6a45b44253988b8dceda43aad157f340aa6e82
Cr-Commit-Position: refs/heads/master@{#14907}