Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2470703002: RTCOutboundRTPStreamStats added (re-land) (Closed)

Created:
4 years, 1 month ago by hbos
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCOutboundRTPStreamStats[1] added. This also adds RTCRTPStreamStats[2] which it derives from. Not all stats are supported in this CL, this must be addressed before closing the issue. RTCStatsReport also gets a timestamp and ToString. [1] https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict* [2] https://w3c.github.io/webrtc-stats/#streamstats-dict* This was previously reverted https://codereview.webrtc.org/2465223002/ because RTCStatsReport::Create added a new parameter not used by Chromium unittests. Temporarily added a default value to the argument to be removed after rolling and updating Chromium. BUG=chromium:627816, chromium:657856, chromium:657854 TBR=deadbeef@webrtc.org Committed: https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf Cr-Commit-Position: refs/heads/master@{#14866}

Patch Set 1 : Original CL 2456463002 #

Patch Set 2 : Default argument for RTCStatsReport::Create #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -20 lines) Patch
M webrtc/api/rtcstatscollector.h View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/api/rtcstatscollector.cc View 9 chunks +136 lines, -4 lines 0 comments Download
M webrtc/api/rtcstatscollector_unittest.cc View 10 chunks +143 lines, -4 lines 0 comments Download
M webrtc/api/stats/rtcstats.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/stats/rtcstats_objects.h View 2 chunks +57 lines, -1 line 0 comments Download
M webrtc/api/stats/rtcstatsreport.h View 1 3 chunks +11 lines, -2 lines 0 comments Download
M webrtc/stats/rtcstats.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/stats/rtcstats_objects.cc View 1 chunk +86 lines, -0 lines 0 comments Download
M webrtc/stats/rtcstatsreport.cc View 4 chunks +23 lines, -3 lines 0 comments Download
M webrtc/stats/rtcstatsreport_unittest.cc View 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
hbos
Please take a re-looksies, hta.
4 years, 1 month ago (2016-11-01 07:30:37 UTC) #3
hta-webrtc
lgtm
4 years, 1 month ago (2016-11-01 07:35:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2470703002/20001
4 years, 1 month ago (2016-11-01 07:36:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2470703002/20001
4 years, 1 month ago (2016-11-01 08:40:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-01 08:50:48 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 08:50:55 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ded19086432b395a85c9a0206fa8a3bc6d33caf
Cr-Commit-Position: refs/heads/master@{#14866}

Powered by Google App Engine
This is Rietveld 408576698