Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2470683002: Revert of RTCInboundRTPStreamStats added. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/rtcstatscollector_unittest.cc ('k') | webrtc/stats/rtcstats_objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/stats/rtcstats_objects.h
diff --git a/webrtc/api/stats/rtcstats_objects.h b/webrtc/api/stats/rtcstats_objects.h
index 4788a1415428f0ea6ed0f238ce979a3c072d4f7e..232e66b388e62524acb27f68d2cdb9220cdce339 100644
--- a/webrtc/api/stats/rtcstats_objects.h
+++ b/webrtc/api/stats/rtcstats_objects.h
@@ -239,48 +239,6 @@
RTCRTPStreamStats(std::string&& id, int64_t timestamp_us);
};
-// https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict*
-// TODO(hbos): Finish implementation and support the remote case
-// |is_remote = true|. Tracking bug crbug.com/657855
-class RTCInboundRTPStreamStats final : public RTCRTPStreamStats {
- public:
- WEBRTC_RTCSTATS_DECL();
-
- RTCInboundRTPStreamStats(const std::string& id, int64_t timestamp_us);
- RTCInboundRTPStreamStats(std::string&& id, int64_t timestamp_us);
- RTCInboundRTPStreamStats(const RTCInboundRTPStreamStats& other);
- ~RTCInboundRTPStreamStats() override;
-
- RTCStatsMember<uint32_t> packets_received;
- RTCStatsMember<uint64_t> bytes_received;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
- RTCStatsMember<uint32_t> packets_lost;
- // TODO(hbos): Not collected in the "video" case by |RTCStatsCollector|.
- // crbug.com/657855
- RTCStatsMember<double> jitter;
- RTCStatsMember<double> fraction_lost;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
- RTCStatsMember<uint32_t> packets_discarded;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
- RTCStatsMember<uint32_t> packets_repaired;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
- RTCStatsMember<uint32_t> burst_packets_lost;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
- RTCStatsMember<uint32_t> burst_packets_discarded;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
- RTCStatsMember<uint32_t> burst_loss_count;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
- RTCStatsMember<uint32_t> burst_discard_count;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
- RTCStatsMember<double> burst_loss_rate;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
- RTCStatsMember<double> burst_discard_rate;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
- RTCStatsMember<double> gap_loss_rate;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
- RTCStatsMember<double> gap_discard_rate;
-};
-
// https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict*
// TODO(hbos): Finish implementation and support the remote case
// |is_remote = true|. Tracking bug crbug.com/657856
« no previous file with comments | « webrtc/api/rtcstatscollector_unittest.cc ('k') | webrtc/stats/rtcstats_objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698