Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2470683002: Revert of RTCInboundRTPStreamStats added. (Closed)

Created:
4 years, 1 month ago by perkj_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of RTCInboundRTPStreamStats added. (patchset #4 id:100001 of https://codereview.webrtc.org/2452043002/ ) Reason for revert: Dependend cl Breaks Chrome FYI. peerconnection_unittest anropar RTCStatsReport::Create without parameters. Original issue's description: > RTCInboundRTPStreamStats[1] added. > > Not all stats are collected in this CL, this must be addressed before > closing the issue. > > [1] https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict* > > BUG=chromium:627816, chromium:657855, chromium:657854 > > Committed: https://crrev.com/0d7bf169402ea9345d163998f4f7df89229ac470 > Cr-Commit-Position: refs/heads/master@{#14861} TBR=hta@webrtc.org,deadbeef@webrtc.org,hbos@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:627816, chromium:657855, chromium:657854 Committed: https://crrev.com/4ed075034a676aad8ec9d65444cb914d4a20b3af Cr-Commit-Position: refs/heads/master@{#14862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -306 lines) Patch
M webrtc/api/rtcstatscollector.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/api/rtcstatscollector.cc View 6 chunks +4 lines, -81 lines 0 comments Download
M webrtc/api/rtcstatscollector_unittest.cc View 6 chunks +14 lines, -116 lines 0 comments Download
M webrtc/api/stats/rtcstats_objects.h View 1 chunk +0 lines, -42 lines 0 comments Download
M webrtc/stats/rtcstats_objects.cc View 1 chunk +0 lines, -66 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
perkj_webrtc
Created Revert of RTCInboundRTPStreamStats added.
4 years, 1 month ago (2016-11-01 06:50:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2470683002/1
4 years, 1 month ago (2016-11-01 06:50:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 06:50:56 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 06:51:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ed075034a676aad8ec9d65444cb914d4a20b3af
Cr-Commit-Position: refs/heads/master@{#14862}

Powered by Google App Engine
This is Rietveld 408576698