Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2470103002: Add new codec for FlexFEC. (Closed)

Created:
4 years, 1 month ago by brandtr
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add new codec for FlexFEC. This CL does nothing except adding new strings and enums corresponding to the new codec. R=stefan@webrtc.org BUG=webrtc:5654 Committed: https://crrev.com/87d7d777002049bd4c3fafc3bd854bda351ccb4d Cr-Commit-Position: refs/heads/master@{#14943}

Patch Set 1 #

Patch Set 2 : Change codec name to 'flexfec-03' and fix tests. #

Total comments: 1

Patch Set 3 : Capitalization. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M webrtc/api/webrtcsdp.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/common_types.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/base/codec.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/base/codec.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/media/base/codec_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/media/base/mediaconstants.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/media/base/mediaconstants.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M webrtc/media/engine/payload_type_mapper.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/payload_type_mapper_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/rtp_frame_reference_finder.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCRtpCodecParameters.mm View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCRtpCodecParameters.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
brandtr
Please have a look :) Do you have a suggestion of somebody from the audio ...
4 years, 1 month ago (2016-11-02 11:50:16 UTC) #1
brandtr
Hey ossu, I saw your name in TODO in a file that I'm touching in ...
4 years, 1 month ago (2016-11-02 12:23:07 UTC) #3
ossu
On 2016/11/02 12:23:07, brandtr wrote: > Hey ossu, > > I saw your name in ...
4 years, 1 month ago (2016-11-02 13:59:41 UTC) #4
stefan-webrtc
lgtm, but please add an owner for webrtc/media and webrtc/sdk too as I don't know ...
4 years, 1 month ago (2016-11-03 13:56:05 UTC) #5
brandtr
Hey magjed and tkchin, Would you mind checking out these changes in "your" corresponding folders? ...
4 years, 1 month ago (2016-11-03 14:34:55 UTC) #7
brandtr
Rebase.
4 years, 1 month ago (2016-11-03 15:31:43 UTC) #8
magjed_webrtc
webrtc/media lgtm
4 years, 1 month ago (2016-11-03 16:01:03 UTC) #9
tkchin_webrtc
On 2016/11/03 16:01:03, magjed_webrtc wrote: > webrtc/media lgtm webrtc/sdk lgtm
4 years, 1 month ago (2016-11-03 23:30:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2470103002/60001
4 years, 1 month ago (2016-11-07 06:41:07 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/19318)
4 years, 1 month ago (2016-11-07 09:43:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2470103002/60001
4 years, 1 month ago (2016-11-07 09:49:14 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-07 11:03:44 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 11:04:13 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/87d7d777002049bd4c3fafc3bd854bda351ccb4d
Cr-Commit-Position: refs/heads/master@{#14943}

Powered by Google App Engine
This is Rietveld 408576698