Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2469783002: Update default values for APM stats to match old behavior. (Closed)

Created:
4 years, 1 month ago by ivoc
Modified:
4 years, 1 month ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update default values for APM stats to match old behavior. In the new APM statistics interface, the default values did not match those previously used in AudioSendStream::Stats. BUG=webrtc:6525 Committed: https://crrev.com/d0a151c6983d0dcb6011d6ca50943f5236dcc084 Cr-Commit-Position: refs/heads/master@{#14896}

Patch Set 1 : Initial version #

Patch Set 2 : Only set stats when getting metrics is succesful. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 1 chunk +9 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 3 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ivoc
Hi Henrik, before hooking up the new statistics interface, we should make sure that the ...
4 years, 1 month ago (2016-11-01 14:31:48 UTC) #4
hlundin-webrtc
lgtm
4 years, 1 month ago (2016-11-02 08:13:56 UTC) #5
ivoc
I updated this CL with a small change to avoid overwriting the default values when ...
4 years, 1 month ago (2016-11-02 15:35:29 UTC) #6
hlundin-webrtc
lgtm
4 years, 1 month ago (2016-11-02 15:50:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2469783002/20001
4 years, 1 month ago (2016-11-02 15:51:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 16:14:40 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 16:20:33 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0a151c6983d0dcb6011d6ca50943f5236dcc084
Cr-Commit-Position: refs/heads/master@{#14896}

Powered by Google App Engine
This is Rietveld 408576698