Passed AudioMixer to AudioState::Config.

Passed AudioMixer to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
with the goal to have a small CL as possible for passing audio through
the new audio mixer in WebRTC. The dependent CL https://codereview.webrtc.org/2436033002/
enables the mixer.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests and
WebRTCVoiceEngine create and pass either a AudioMixerImpl.
WebRTCVoiceEngine passes a real AudioMixer, which is
currently unused.

An alternative would have tests pass a mocked audio mixer. We
chose not to do that, because we believe that tests should use
the real thing unless there are reasons against it. Construction
time is not an issue, because the real mixer is relatively
lightweight.

We couldn't find a way to test any mixer-related changes in AudioState
before the mixes is connected. The next dependent CL
https://codereview.webrtc.org/2436033002/ contains unit tests for
mixer usage.

BUG=webrtc:6346
Committed: https://crrev.com/10111bc49539589113c76318b7ba53591946e78a
Cr-Commit-Position: refs/heads/master@{#15134}

[aleloi, 2016-11-01 14:44:10]

Description was changed from

==========
Passed AudioMixer* to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is unique_ptr<AudioMixer>.

Populating this field has now been mandatory. Tests create and pass
either a mock or a real AudioMixerImpl. WebRTCVoiceEngine passes a
real AudioMixer, which is currently unused.

BUG=webrtc:6346
==========

to

==========
Passed AudioMixer* to AudioState::Config.

WORK IN PROGRESS; DO NOT SUBMIT IN PRESENT STATE: A mock mixer is planned; tests
that do not need 'real' mixing will create mock mixer.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is unique_ptr<AudioMixer>.

Populating this field has now been mandatory. Tests create and pass
either a mock or a real AudioMixerImpl. WebRTCVoiceEngine passes a
real AudioMixer, which is currently unused.

BUG=webrtc:6346
==========

[aleloi, 2016-11-01 14:45:00]

Description was changed from

==========
Passed AudioMixer* to AudioState::Config.

WORK IN PROGRESS; DO NOT SUBMIT IN PRESENT STATE: A mock mixer is planned; tests
that do not need 'real' mixing will create mock mixer.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is unique_ptr<AudioMixer>.

Populating this field has now been mandatory. Tests create and pass
either a mock or a real AudioMixerImpl. WebRTCVoiceEngine passes a
real AudioMixer, which is currently unused.

BUG=webrtc:6346
==========

to

==========
Passed AudioMixer* to AudioState::Config.

WORK IN PROGRESS; DO NOT SUBMIT IN PRESENT STATE: A mock mixer is planned; tests
that do not need 'real' mixing will create mock mixer; Gyp tests are not
updated.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is unique_ptr<AudioMixer>.

Populating this field has now been mandatory. Tests create and pass
either a mock or a real AudioMixerImpl. WebRTCVoiceEngine passes a
real AudioMixer, which is currently unused.

BUG=webrtc:6346
==========

[aleloi, 2016-11-08 12:10:42]

Patchset #2 (id:20001) has been deleted

[aleloi, 2016-11-08 12:10:57]

Patchset #1 (id:1) has been deleted

[aleloi, 2016-11-08 15:17:24]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 15:17:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[aleloi, 2016-11-08 15:18:11]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-11-08 15:19:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 15:19:59]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
  android_more_configs on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_more_configs/bu...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/14645)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/14522)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/19876)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/18566)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/19222)

[aleloi, 2016-11-08 15:29:09]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 15:29:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[aleloi, 2016-11-08 15:30:19]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-11-08 15:55:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 15:55:24]

Dry run: This issue passed the CQ dry run.

[aleloi, 2016-11-10 09:37:14]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 09:37:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-10 09:48:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 09:48:33]

Dry run: Try jobs failed on following builders:
  win_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/12939)

[aleloi, 2016-11-10 10:05:55]

Patchset #1 (id:80001) has been deleted

[aleloi, 2016-11-14 16:13:17]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 16:13:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[aleloi, 2016-11-14 16:14:30]

Patchset #1 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-11-14 16:14:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 16:14:38]

Dry run: Try jobs failed on following builders:
  android_more_configs on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_more_configs/bu...)
  ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/12478)
  ios64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gyp_dbg/builds/2356)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/14833)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/14706)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/20061)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/18759)

[aleloi, 2016-11-14 16:14:41]

Patchset #1 (id:120001) has been deleted

[aleloi, 2016-11-14 16:22:14]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[aleloi, 2016-11-14 16:22:21]

Patchset #1 (id:140001) has been deleted

[commit-bot: I haz the power, 2016-11-14 16:22:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-14 16:28:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 16:28:31]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10172)

[aleloi, 2016-11-14 16:28:54]

Description was changed from

==========
Passed AudioMixer* to AudioState::Config.

WORK IN PROGRESS; DO NOT SUBMIT IN PRESENT STATE: A mock mixer is planned; tests
that do not need 'real' mixing will create mock mixer; Gyp tests are not
updated.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is unique_ptr<AudioMixer>.

Populating this field has now been mandatory. Tests create and pass
either a mock or a real AudioMixerImpl. WebRTCVoiceEngine passes a
real AudioMixer, which is currently unused.

BUG=webrtc:6346
==========

to

==========
Passed AudioMixer* to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is unique_ptr<AudioMixer>.

Populating this field has now been mandatory. Tests create and pass
either a mock or a real AudioMixerImpl. WebRTCVoiceEngine passes a
real AudioMixer, which is currently unused.

BUG=webrtc:6346
==========

[aleloi, 2016-11-14 16:31:04]

Description was changed from

==========
Passed AudioMixer* to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is unique_ptr<AudioMixer>.

Populating this field has now been mandatory. Tests create and pass
either a mock or a real AudioMixerImpl. WebRTCVoiceEngine passes a
real AudioMixer, which is currently unused.

BUG=webrtc:6346
==========

to

==========
Passed AudioMixer* to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests create and pass
either a mock or a real AudioMixerImpl. WebRTCVoiceEngine passes a
real AudioMixer, which is currently unused.

BUG=webrtc:6346
==========

[aleloi, 2016-11-14 16:36:14]

Description was changed from

==========
Passed AudioMixer* to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests create and pass
either a mock or a real AudioMixerImpl. WebRTCVoiceEngine passes a
real AudioMixer, which is currently unused.

BUG=webrtc:6346
==========

to

==========
Passed AudioMixer* to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests and 
WebRTCVoiceEngine create and pass either a AudioMixerImpl.
WebRTCVoiceEngine passes a real AudioMixer, which is
currently unused.

An alternative would have tests pass a mocked audio mixer. We
chose not to do that, because we believe that tests should use
the real thing unless there are reasons against it. Construction
time is not an issue, because the real mixer is relatively
lightweight.



BUG=webrtc:6346
==========

[aleloi, 2016-11-14 16:38:45]

Description was changed from

==========
Passed AudioMixer* to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests and 
WebRTCVoiceEngine create and pass either a AudioMixerImpl.
WebRTCVoiceEngine passes a real AudioMixer, which is
currently unused.

An alternative would have tests pass a mocked audio mixer. We
chose not to do that, because we believe that tests should use
the real thing unless there are reasons against it. Construction
time is not an issue, because the real mixer is relatively
lightweight.



BUG=webrtc:6346
==========

to

==========
Passed AudioMixer* to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests and 
WebRTCVoiceEngine create and pass either a AudioMixerImpl.
WebRTCVoiceEngine passes a real AudioMixer, which is
currently unused.

An alternative would have tests pass a mocked audio mixer. We
chose not to do that, because we believe that tests should use
the real thing unless there are reasons against it. Construction
time is not an issue, because the real mixer is relatively
lightweight.

We couldn't find a way to test any mixer-related changes in AudioState
before the mixes is connected. The next dependent CL 
https://codereview.webrtc.org/2436033002/ contains unit tests for
mixer usage.

BUG=webrtc:6346
==========

[aleloi, 2016-11-14 16:39:57]

aleloi@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[aleloi, 2016-11-14 16:39:59]

Hi! Can you take a look?

It's a refactoring CL full of 2-line changes in lots of files.

https://codereview.webrtc.org/2469743002/diff/160001/webrtc/audio/BUILD.gn
File webrtc/audio/BUILD.gn (right):

https://codereview.webrtc.org/2469743002/diff/160001/webrtc/audio/BUILD.gn#ne...
webrtc/audio/BUILD.gn:51: "../base:rtc_base_approved",
Missed dep according to GN.

https://codereview.webrtc.org/2469743002/diff/160001/webrtc/audio/BUILD.gn#ne...
webrtc/audio/BUILD.gn:53: "../test:test_common",
For including mock_voice_engine.

https://codereview.webrtc.org/2469743002/diff/160001/webrtc/modules/audio_mix...
File webrtc/modules/audio_mixer/BUILD.gn (left):

https://codereview.webrtc.org/2469743002/diff/160001/webrtc/modules/audio_mix...
webrtc/modules/audio_mixer/BUILD.gn:19: visibility = [
Removed since almost everyone and their dog creates a mixer now.

[the sun, 2016-11-14 20:14:21]

solenberg@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[the sun, 2016-11-14 20:14:22]

https://codereview.webrtc.org/2469743002/diff/160001/webrtc/audio/audio_state.cc
File webrtc/audio/audio_state.cc (right):

https://codereview.webrtc.org/2469743002/diff/160001/webrtc/audio/audio_state...
webrtc/audio/audio_state.cc:52: rtc::scoped_refptr<AudioMixer>
AudioState::mixer() {
Missing
RTC_DCHECK(thread_checker_.CalledOnValidThread());

https://codereview.webrtc.org/2469743002/diff/160001/webrtc/call/call_unittes...
File webrtc/call/call_unittest.cc (right):

https://codereview.webrtc.org/2469743002/diff/160001/webrtc/call/call_unittes...
webrtc/call/call_unittest.cc:34: audio_state_config.audio_mixer =
webrtc::AudioMixerImpl::Create();
Move up (line 29)

[the sun, 2016-11-14 20:14:33]

solenberg@webrtc.org changed reviewers:
- solenberg@webrtc.org

[kwiberg-webrtc, 2016-11-15 04:58:16]

lgtm, if you fix the things solenberg pointed out

[kwiberg-webrtc, 2016-11-15 05:01:09]

By the way, please change the title a bit. With "AudioMixer*", it sounds like
you're talking about a raw pointer. Saying just "AudioMixer" is probably
detailed enough.

[aleloi, 2016-11-15 08:09:21]

Description was changed from

==========
Passed AudioMixer* to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests and 
WebRTCVoiceEngine create and pass either a AudioMixerImpl.
WebRTCVoiceEngine passes a real AudioMixer, which is
currently unused.

An alternative would have tests pass a mocked audio mixer. We
chose not to do that, because we believe that tests should use
the real thing unless there are reasons against it. Construction
time is not an issue, because the real mixer is relatively
lightweight.

We couldn't find a way to test any mixer-related changes in AudioState
before the mixes is connected. The next dependent CL 
https://codereview.webrtc.org/2436033002/ contains unit tests for
mixer usage.

BUG=webrtc:6346
==========

to

==========
Passed AudioMixer to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests and 
WebRTCVoiceEngine create and pass either a AudioMixerImpl.
WebRTCVoiceEngine passes a real AudioMixer, which is
currently unused.

An alternative would have tests pass a mocked audio mixer. We
chose not to do that, because we believe that tests should use
the real thing unless there are reasons against it. Construction
time is not an issue, because the real mixer is relatively
lightweight.

We couldn't find a way to test any mixer-related changes in AudioState
before the mixes is connected. The next dependent CL 
https://codereview.webrtc.org/2436033002/ contains unit tests for
mixer usage.

BUG=webrtc:6346
==========

[aleloi, 2016-11-15 08:11:37]

Description was changed from

==========
Passed AudioMixer to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
https://codereview.webrtc.org/2436033002/ with the goal is to have
a small CL as possible for enabling the new audio mixer in WebRTC.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests and 
WebRTCVoiceEngine create and pass either a AudioMixerImpl.
WebRTCVoiceEngine passes a real AudioMixer, which is
currently unused.

An alternative would have tests pass a mocked audio mixer. We
chose not to do that, because we believe that tests should use
the real thing unless there are reasons against it. Construction
time is not an issue, because the real mixer is relatively
lightweight.

We couldn't find a way to test any mixer-related changes in AudioState
before the mixes is connected. The next dependent CL 
https://codereview.webrtc.org/2436033002/ contains unit tests for
mixer usage.

BUG=webrtc:6346
==========

to

==========
Passed AudioMixer to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
with the goal to have a small CL as possible for passing audio through
the new audio mixer in WebRTC. The dependent CL
https://codereview.webrtc.org/2436033002/
enables the mixer.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests and 
WebRTCVoiceEngine create and pass either a AudioMixerImpl.
WebRTCVoiceEngine passes a real AudioMixer, which is
currently unused.

An alternative would have tests pass a mocked audio mixer. We
chose not to do that, because we believe that tests should use
the real thing unless there are reasons against it. Construction
time is not an issue, because the real mixer is relatively
lightweight.

We couldn't find a way to test any mixer-related changes in AudioState
before the mixes is connected. The next dependent CL 
https://codereview.webrtc.org/2436033002/ contains unit tests for
mixer usage.

BUG=webrtc:6346
==========

[aleloi, 2016-11-17 14:31:40]

The CQ bit was checked by aleloi@webrtc.org

[aleloi, 2016-11-17 14:31:40]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2469743002/#ps200001 (title:
"Rebase. GYP removed!")

[commit-bot: I haz the power, 2016-11-17 14:31:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-17 14:48:50]

Description was changed from

==========
Passed AudioMixer to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
with the goal to have a small CL as possible for passing audio through
the new audio mixer in WebRTC. The dependent CL
https://codereview.webrtc.org/2436033002/
enables the mixer.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests and 
WebRTCVoiceEngine create and pass either a AudioMixerImpl.
WebRTCVoiceEngine passes a real AudioMixer, which is
currently unused.

An alternative would have tests pass a mocked audio mixer. We
chose not to do that, because we believe that tests should use
the real thing unless there are reasons against it. Construction
time is not an issue, because the real mixer is relatively
lightweight.

We couldn't find a way to test any mixer-related changes in AudioState
before the mixes is connected. The next dependent CL 
https://codereview.webrtc.org/2436033002/ contains unit tests for
mixer usage.

BUG=webrtc:6346
==========

to

==========
Passed AudioMixer to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
with the goal to have a small CL as possible for passing audio through
the new audio mixer in WebRTC. The dependent CL
https://codereview.webrtc.org/2436033002/
enables the mixer.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests and 
WebRTCVoiceEngine create and pass either a AudioMixerImpl.
WebRTCVoiceEngine passes a real AudioMixer, which is
currently unused.

An alternative would have tests pass a mocked audio mixer. We
chose not to do that, because we believe that tests should use
the real thing unless there are reasons against it. Construction
time is not an issue, because the real mixer is relatively
lightweight.

We couldn't find a way to test any mixer-related changes in AudioState
before the mixes is connected. The next dependent CL 
https://codereview.webrtc.org/2436033002/ contains unit tests for
mixer usage.

BUG=webrtc:6346
==========

[commit-bot: I haz the power, 2016-11-17 14:48:51]

Committed patchset #3 (id:200001)

[commit-bot: I haz the power, 2016-11-17 14:49:00]

Description was changed from

==========
Passed AudioMixer to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
with the goal to have a small CL as possible for passing audio through
the new audio mixer in WebRTC. The dependent CL
https://codereview.webrtc.org/2436033002/
enables the mixer.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests and 
WebRTCVoiceEngine create and pass either a AudioMixerImpl.
WebRTCVoiceEngine passes a real AudioMixer, which is
currently unused.

An alternative would have tests pass a mocked audio mixer. We
chose not to do that, because we believe that tests should use
the real thing unless there are reasons against it. Construction
time is not an issue, because the real mixer is relatively
lightweight.

We couldn't find a way to test any mixer-related changes in AudioState
before the mixes is connected. The next dependent CL 
https://codereview.webrtc.org/2436033002/ contains unit tests for
mixer usage.

BUG=webrtc:6346
==========

to

==========
Passed AudioMixer to AudioState::Config.

This is a refactoring change in preparation for enabling AudioMixer
with the goal to have a small CL as possible for passing audio through
the new audio mixer in WebRTC. The dependent CL
https://codereview.webrtc.org/2436033002/
enables the mixer.

An object of class AudioState is shared across different webrtc audio
connections. It is created in tests and in
WebRTCVoiceEngine. AudioState is constructed by passing a Config
struct, where one argument is scoped_refptr<AudioMixer>.

Populating this field has now been mandatory. Tests and
WebRTCVoiceEngine create and pass either a AudioMixerImpl.
WebRTCVoiceEngine passes a real AudioMixer, which is
currently unused.

An alternative would have tests pass a mocked audio mixer. We
chose not to do that, because we believe that tests should use
the real thing unless there are reasons against it. Construction
time is not an issue, because the real mixer is relatively
lightweight.

We couldn't find a way to test any mixer-related changes in AudioState
before the mixes is connected. The next dependent CL
https://codereview.webrtc.org/2436033002/ contains unit tests for
mixer usage.

BUG=webrtc:6346

Committed: https://crrev.com/10111bc49539589113c76318b7ba53591946e78a
Cr-Commit-Position: refs/heads/master@{#15134}
==========

[commit-bot: I haz the power, 2016-11-17 14:49:01]

Patchset 3 (id:??) landed as
https://crrev.com/10111bc49539589113c76318b7ba53591946e78a
Cr-Commit-Position: refs/heads/master@{#15134}