Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Side by Side Diff: webrtc/video/video_send_stream_tests.cc

Issue 2469093003: Remove RED/RTX workaround from sender/receiver and VideoEngine2. (Closed)
Patch Set: Fix warning message. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/video/video_send_stream.cc ('k') | webrtc/video_receive_stream.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> // max 10 #include <algorithm> // max
(...skipping 500 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 // The FEC scheme used is not efficient for H264, so we should not use RED/FEC 511 // The FEC scheme used is not efficient for H264, so we should not use RED/FEC
512 // since we'll still have to re-request FEC packets, effectively wasting 512 // since we'll still have to re-request FEC packets, effectively wasting
513 // bandwidth since the receiver has to wait for FEC retransmissions to determine 513 // bandwidth since the receiver has to wait for FEC retransmissions to determine
514 // that the received state is actually decodable. 514 // that the received state is actually decodable.
515 TEST_F(VideoSendStreamTest, DoesNotUtilizeUlpfecForH264WithNackEnabled) { 515 TEST_F(VideoSendStreamTest, DoesNotUtilizeUlpfecForH264WithNackEnabled) {
516 UlpfecObserver test(false, true, true, false, "H264"); 516 UlpfecObserver test(false, true, true, false, "H264");
517 RunBaseTest(&test); 517 RunBaseTest(&test);
518 } 518 }
519 519
520 // Without retransmissions FEC for H264 is fine. 520 // Without retransmissions FEC for H264 is fine.
521 TEST_F(VideoSendStreamTest, DoesUtilizeRedForH264WithoutNackEnabled) { 521 TEST_F(VideoSendStreamTest, DoesUtilizeUlpfecForH264WithoutNackEnabled) {
522 UlpfecObserver test(false, false, true, true, "H264"); 522 UlpfecObserver test(false, false, true, true, "H264");
523 RunBaseTest(&test); 523 RunBaseTest(&test);
524 } 524 }
525 525
526 TEST_F(VideoSendStreamTest, DoesUtilizeRedForVp8WithNackEnabled) { 526 TEST_F(VideoSendStreamTest, DoesUtilizeUlpfecForVp8WithNackEnabled) {
527 UlpfecObserver test(false, true, true, true, "VP8"); 527 UlpfecObserver test(false, true, true, true, "VP8");
528 RunBaseTest(&test); 528 RunBaseTest(&test);
529 } 529 }
530 530
531 #if !defined(RTC_DISABLE_VP9) 531 #if !defined(RTC_DISABLE_VP9)
532 TEST_F(VideoSendStreamTest, DoesUtilizeRedForVp9WithNackEnabled) { 532 TEST_F(VideoSendStreamTest, DoesUtilizeUlpfecForVp9WithNackEnabled) {
533 UlpfecObserver test(false, true, true, true, "VP9"); 533 UlpfecObserver test(false, true, true, true, "VP9");
534 RunBaseTest(&test); 534 RunBaseTest(&test);
535 } 535 }
536 #endif // !defined(RTC_DISABLE_VP9) 536 #endif // !defined(RTC_DISABLE_VP9)
537 537
538 void VideoSendStreamTest::TestNackRetransmission( 538 void VideoSendStreamTest::TestNackRetransmission(
539 uint32_t retransmit_ssrc, 539 uint32_t retransmit_ssrc,
540 uint8_t retransmit_payload_type) { 540 uint8_t retransmit_payload_type) {
541 class NackObserver : public test::SendTest { 541 class NackObserver : public test::SendTest {
542 public: 542 public:
(...skipping 2444 matching lines...) Expand 10 before | Expand all | Expand 10 after
2987 RequestSourceRotateIfVideoOrientationExtensionNotSupported) { 2987 RequestSourceRotateIfVideoOrientationExtensionNotSupported) {
2988 TestRequestSourceRotateVideo(false); 2988 TestRequestSourceRotateVideo(false);
2989 } 2989 }
2990 2990
2991 TEST_F(VideoSendStreamTest, 2991 TEST_F(VideoSendStreamTest,
2992 DoNotRequestsRotationIfVideoOrientationExtensionSupported) { 2992 DoNotRequestsRotationIfVideoOrientationExtensionSupported) {
2993 TestRequestSourceRotateVideo(true); 2993 TestRequestSourceRotateVideo(true);
2994 } 2994 }
2995 2995
2996 } // namespace webrtc 2996 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/video/video_send_stream.cc ('k') | webrtc/video_receive_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698