Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Side by Side Diff: webrtc/video/video_send_stream_tests.cc

Issue 2469093003: Remove RED/RTX workaround from sender/receiver and VideoEngine2. (Closed)
Patch Set: Remove RED/RTX workaround from sender/receiver and VideoEngine2. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> // max 10 #include <algorithm> // max
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 TEST_F(VideoSendStreamTest, SupportsUlpfecWithoutExtensions) { 510 TEST_F(VideoSendStreamTest, SupportsUlpfecWithoutExtensions) {
511 UlpfecObserver test(false, false, true, true, "VP8"); 511 UlpfecObserver test(false, false, true, true, "VP8");
512 RunBaseTest(&test); 512 RunBaseTest(&test);
513 } 513 }
514 514
515 // The FEC scheme used is not efficient for H264, so we should not use RED/FEC 515 // The FEC scheme used is not efficient for H264, so we should not use RED/FEC
516 // since we'll still have to re-request FEC packets, effectively wasting 516 // since we'll still have to re-request FEC packets, effectively wasting
517 // bandwidth since the receiver has to wait for FEC retransmissions to determine 517 // bandwidth since the receiver has to wait for FEC retransmissions to determine
518 // that the received state is actually decodable. 518 // that the received state is actually decodable.
519 TEST_F(VideoSendStreamTest, DoesNotUtilizeUlpfecForH264WithNackEnabled) { 519 TEST_F(VideoSendStreamTest, DoesNotUtilizeUlpfecForH264WithNackEnabled) {
520 UlpfecObserver test(false, true, true, false, "H264"); 520 UlpfecObserver test(false, true, false, false, "H264");
521 RunBaseTest(&test); 521 RunBaseTest(&test);
522 } 522 }
523 523
524 // Without retransmissions FEC for H264 is fine. 524 // Without retransmissions FEC for H264 is fine.
525 TEST_F(VideoSendStreamTest, DoesUtilizeRedForH264WithoutNackEnabled) { 525 TEST_F(VideoSendStreamTest, DoesUtilizeUlpfecForH264WithoutNackEnabled) {
526 UlpfecObserver test(false, false, true, true, "H264"); 526 UlpfecObserver test(false, false, true, true, "H264");
527 RunBaseTest(&test); 527 RunBaseTest(&test);
528 } 528 }
529 529
530 TEST_F(VideoSendStreamTest, DoesUtilizeRedForVp8WithNackEnabled) { 530 TEST_F(VideoSendStreamTest, DoesUtilizeUlpfecForVp8WithNackEnabled) {
531 UlpfecObserver test(false, true, true, true, "VP8"); 531 UlpfecObserver test(false, true, true, true, "VP8");
532 RunBaseTest(&test); 532 RunBaseTest(&test);
533 } 533 }
534 534
535 #if !defined(RTC_DISABLE_VP9) 535 #if !defined(RTC_DISABLE_VP9)
536 TEST_F(VideoSendStreamTest, DoesUtilizeRedForVp9WithNackEnabled) { 536 TEST_F(VideoSendStreamTest, DoesUtilizeUlpfecForVp9WithNackEnabled) {
537 UlpfecObserver test(false, true, true, true, "VP9"); 537 UlpfecObserver test(false, true, true, true, "VP9");
538 RunBaseTest(&test); 538 RunBaseTest(&test);
539 } 539 }
540 #endif // !defined(RTC_DISABLE_VP9) 540 #endif // !defined(RTC_DISABLE_VP9)
541 541
542 void VideoSendStreamTest::TestNackRetransmission( 542 void VideoSendStreamTest::TestNackRetransmission(
543 uint32_t retransmit_ssrc, 543 uint32_t retransmit_ssrc,
544 uint8_t retransmit_payload_type) { 544 uint8_t retransmit_payload_type) {
545 class NackObserver : public test::SendTest { 545 class NackObserver : public test::SendTest {
546 public: 546 public:
(...skipping 2402 matching lines...) Expand 10 before | Expand all | Expand 10 after
2949 RequestSourceRotateIfVideoOrientationExtensionNotSupported) { 2949 RequestSourceRotateIfVideoOrientationExtensionNotSupported) {
2950 TestRequestSourceRotateVideo(false); 2950 TestRequestSourceRotateVideo(false);
2951 } 2951 }
2952 2952
2953 TEST_F(VideoSendStreamTest, 2953 TEST_F(VideoSendStreamTest,
2954 DoNotRequestsRotationIfVideoOrientationExtensionSupported) { 2954 DoNotRequestsRotationIfVideoOrientationExtensionSupported) {
2955 TestRequestSourceRotateVideo(true); 2955 TestRequestSourceRotateVideo(true);
2956 } 2956 }
2957 2957
2958 } // namespace webrtc 2958 } // namespace webrtc
OLDNEW
« webrtc/video/video_send_stream.cc ('K') | « webrtc/video/video_send_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698