Remove RED/RTX workaround from sender/receiver and VideoEngine2.

webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h"
 
 #include "webrtc/base/logging.h"
 #include "webrtc/modules/rtp_rtcp/source/byte_io.h"
 
 namespace webrtc {
 
 RTPPayloadRegistry::RTPPayloadRegistry(RTPPayloadStrategy* rtp_payload_strategy)
     : rtp_payload_strategy_(rtp_payload_strategy),
       red_payload_type_(-1),
       ulpfec_payload_type_(-1),
       incoming_payload_type_(-1),
       last_received_payload_type_(-1),
       last_received_media_payload_type_(-1),
       rtx_(false),
-      rtx_payload_type_(-1),
       ssrc_rtx_(0) {}
 
 RTPPayloadRegistry::~RTPPayloadRegistry() {
   while (!payload_type_map_.empty()) {
     RtpUtility::PayloadTypeMap::iterator it = payload_type_map_.begin();
     delete it->second;
     payload_type_map_.erase(it);
   }
 }
 
@@ skipping 214 matching lines @@
 
   // Replace the SSRC and the sequence number with the originals.
   ByteWriter<uint16_t>::WriteBigEndian(restored_packet + 2,
                                        original_sequence_number);
   ByteWriter<uint32_t>::WriteBigEndian(restored_packet + 8, original_ssrc);
 
   rtc::CritScope cs(&crit_sect_);
   if (!rtx_)
     return true;
 
   int associated_payload_type;

[danilchap, 2016/11/02 13:56:52]

might as well remove this variable and use apt_mapping->second directly now.

[brandtr, 2016/11/03 12:02:48]

Kept, because now I use it in multiple places.

   auto apt_mapping = rtx_payload_type_map_.find(header.payloadType);
-  if (apt_mapping == rtx_payload_type_map_.end())
+  if (apt_mapping == rtx_payload_type_map_.end()) {
+    LOG(LS_WARNING) << "No RTX associated payload type mapping was available; "

[danilchap, 2016/11/02 13:56:52]

Better to ensure you do not spam this messages (If there is an rtx packet with
mismatch payload_type, likely there will be a lot of them).

[brandtr, 2016/11/03 12:02:48]

Done.

+                       "not able to restore original packet from RTX packet "
+                       "with payload type: "
+                    << header.payloadType << ".";
     return false;
+  }
   associated_payload_type = apt_mapping->second;
-  if (red_payload_type_ != -1) {
-    // Assume red will be used if it's configured.
-    // This is a workaround for a Chrome sdp bug where rtx is associated
-    // with the media codec even though media is sent over red.
-    // TODO(holmer): Remove once the Chrome versions exposing this bug are
-    // old enough, which should be once Chrome Stable reaches M53 as this
-    // work-around went into M50.
-    associated_payload_type = red_payload_type_;
-  }
   restored_packet[1] = static_cast<uint8_t>(associated_payload_type);
   if (header.markerBit) {
     restored_packet[1] |= kRtpMarkerBitMask;  // Marker bit is set.
   }
   return true;
 }
 
 void RTPPayloadRegistry::SetRtxSsrc(uint32_t ssrc) {
   rtc::CritScope cs(&crit_sect_);
   ssrc_rtx_ = ssrc;
   rtx_ = true;
 }
 
 bool RTPPayloadRegistry::GetRtxSsrc(uint32_t* ssrc) const {
   rtc::CritScope cs(&crit_sect_);
   *ssrc = ssrc_rtx_;
   return rtx_;
 }
 
 void RTPPayloadRegistry::SetRtxPayloadType(int payload_type,
                                            int associated_payload_type) {
   rtc::CritScope cs(&crit_sect_);
   if (payload_type < 0) {
     LOG(LS_ERROR) << "Invalid RTX payload type: " << payload_type;
     return;
   }
 
   rtx_payload_type_map_[payload_type] = associated_payload_type;
   rtx_ = true;
-  rtx_payload_type_ = payload_type;
 }
 
 bool RTPPayloadRegistry::IsRed(const RTPHeader& header) const {
   rtc::CritScope cs(&crit_sect_);
   return red_payload_type_ == header.payloadType;
 }
 
 bool RTPPayloadRegistry::IsEncapsulated(const RTPHeader& header) const {
   return IsRed(header) || IsRtx(header);
 }
@@ skipping 151 matching lines @@
 RTPPayloadStrategy* RTPPayloadStrategy::CreateStrategy(
     const bool handling_audio) {
   if (handling_audio) {
     return new RTPPayloadAudioStrategy();
   } else {
     return new RTPPayloadVideoStrategy();
   }
 }
 
 }  // namespace webrtc