Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2468943002:
More tolerant format name for FileVideoCapturer (Closed)
DescriptionMore tolerant format name for FileVideoCapturer
Before only C420 as format name was accepted, now C420mpeg2 is also
accepted. Both means the same thing.
BUG=webrtc:6545
NOTRY=True
Committed: https://crrev.com/d192dce1c5f736e2453cd8f8567b1ce36822d00d
Cr-Commit-Position: refs/heads/master@{#14897}
Patch Set 1 #
Messages
Total messages: 21 (15 generated)
mandermo@webrtc.org changed reviewers: + kjellander@webrtc.org, magjed@webrtc.org
More tolerant format name for FileVideoCapturer Before only C420 as format name was accepted, now C420mpeg2 is also accepted. Both means the same thing.
lgtm, run a few compile trybot and add NOTRY=True before landing this.
Description was changed from ========== More tolerant format name for FileVideoCapturer Before only C420 as format name was accepted, now C420mpeg2 is also accepted. Both means the same thing. BUG=6545 ========== to ========== More tolerant format name for FileVideoCapturer Before only C420 as format name was accepted, now C420mpeg2 is also accepted. Both means the same thing. BUG=6545 NOTRY=True ==========
The CQ bit was checked by mandermo@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was unchecked by mandermo@webrtc.org
lgtm. You need to prefix the issue with 'webrtc', i.e. BUG=webrtc:6545.
Description was changed from ========== More tolerant format name for FileVideoCapturer Before only C420 as format name was accepted, now C420mpeg2 is also accepted. Both means the same thing. BUG=6545 NOTRY=True ========== to ========== More tolerant format name for FileVideoCapturer Before only C420 as format name was accepted, now C420mpeg2 is also accepted. Both means the same thing. BUG=webrtc:6545 NOTRY=True ==========
The CQ bit was checked by mandermo@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mandermo@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== More tolerant format name for FileVideoCapturer Before only C420 as format name was accepted, now C420mpeg2 is also accepted. Both means the same thing. BUG=webrtc:6545 NOTRY=True ========== to ========== More tolerant format name for FileVideoCapturer Before only C420 as format name was accepted, now C420mpeg2 is also accepted. Both means the same thing. BUG=webrtc:6545 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== More tolerant format name for FileVideoCapturer Before only C420 as format name was accepted, now C420mpeg2 is also accepted. Both means the same thing. BUG=webrtc:6545 NOTRY=True ========== to ========== More tolerant format name for FileVideoCapturer Before only C420 as format name was accepted, now C420mpeg2 is also accepted. Both means the same thing. BUG=webrtc:6545 NOTRY=True Committed: https://crrev.com/d192dce1c5f736e2453cd8f8567b1ce36822d00d Cr-Commit-Position: refs/heads/master@{#14897} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d192dce1c5f736e2453cd8f8567b1ce36822d00d Cr-Commit-Position: refs/heads/master@{#14897} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
