Remove webrtc::Video from H264 encoder internals

webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  *
  */
@@ skipping 52 matching lines @@
   bool IsInitialized() const;
   SEncParamExt CreateEncoderParams() const;
 
   webrtc::H264BitstreamParser h264_bitstream_parser_;
   QualityScaler quality_scaler_;
   // Reports statistics with histograms.
   void ReportInit();
   void ReportError();
 
   ISVCEncoder* openh264_encoder_;
-  VideoCodec codec_settings_;
+  // Settings that are used by this encoder.
+  int width_;
+  int height_;
+  unsigned char maxFramerate_;
+  unsigned int targetBitrate_;  // kilobits/sec.
+  unsigned int maxBitrate_;
+  VideoCodecMode mode_;
+  // H.264 specifc parameters
+  bool frameDroppingOn_;
+  int keyFrameInterval_;

[stefan-webrtc, 2016/11/02 11:14:21]

I would prefer to get rid of the camelCase while you're at it.

[hta-webrtc, 2016/11/02 12:35:43]

Done.

While I was at it I changed the types to match what they are used for within the
module rather than what they are passed in at, and made the casts /
multiplications where they are set.

+
   int32_t number_of_cores_;
 
   EncodedImage encoded_image_;
   std::unique_ptr<uint8_t[]> encoded_image_buffer_;
   EncodedImageCallback* encoded_image_callback_;
 
   bool has_reported_init_;
   bool has_reported_error_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_VIDEO_CODING_CODECS_H264_H264_ENCODER_IMPL_H_