Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2468413009: Revert of Change TWCC send interval to reduce overhead on low BW situations. (Closed)

Created:
4 years, 1 month ago by ivoc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Change TWCC send interval to reduce overhead on low BW situations. (patchset #10 id:200001 of https://codereview.webrtc.org/2381833003/ ) Reason for revert: Breaks internal tests. Original issue's description: > Change TWCC send interval to reduce overhead on low BW situations. > > BUG=webrtc:6442 > > Committed: https://crrev.com/861e9374640eaa37ba5d905e3e0971df04b4fc9e > Cr-Commit-Position: refs/heads/master@{#14910} TBR=minyue@webrtc.org,stefan@webrtc.org,michaelt@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6442 Committed: https://crrev.com/3326d0ac8232d6e9f6cd696b63f88bd817b0ec62 Cr-Commit-Position: refs/heads/master@{#14933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -66 lines) Patch
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h View 2 chunks +1 line, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc View 5 chunks +6 lines, -28 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy_unittest.cc View 2 chunks +1 line, -32 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ivoc
Created Revert of Change TWCC send interval to reduce overhead on low BW situations.
4 years, 1 month ago (2016-11-04 16:22:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2468413009/1
4 years, 1 month ago (2016-11-04 16:22:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 16:48:41 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 17:15:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3326d0ac8232d6e9f6cd696b63f88bd817b0ec62
Cr-Commit-Position: refs/heads/master@{#14933}

Powered by Google App Engine
This is Rietveld 408576698