Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2468253002: Suppress WebRtcVideoEncoderFactory overloaded virtual function warning (Closed)

Created:
4 years, 1 month ago by magjed_webrtc
Modified:
4 years, 1 month ago
Reviewers:
ivoc, ivoc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Suppress WebRtcVideoEncoderFactory overloaded virtual function warning Suppress WebRtcVideoEncoderFactory overloaded virtual function warning in WebRtcSimulcastEncoderFactory and FakeWebRtcVideoEncoderFactory. This warning is triggered by the change in this CL: https://codereview.webrtc.org/2449993003/. BUG=webrtc:6402, webrtc:6337 Committed: https://crrev.com/d2fce1744f9cfc4fceaa971e6b394d0d1fa7248b Cr-Commit-Position: refs/heads/master@{#14901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M webrtc/media/engine/fakewebrtcvideoengine.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
magjed_webrtc
Ivo - please take a look.
4 years, 1 month ago (2016-11-02 16:22:39 UTC) #3
ivoc
LGTM.
4 years, 1 month ago (2016-11-02 16:24:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2468253002/1
4 years, 1 month ago (2016-11-02 18:06:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 18:08:32 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 18:22:31 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2fce1744f9cfc4fceaa971e6b394d0d1fa7248b
Cr-Commit-Position: refs/heads/master@{#14901}

Powered by Google App Engine
This is Rietveld 408576698