Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Side by Side Diff: webrtc/media/media.gyp

Issue 2468093004: WebRTC: Fix and enable -Woverloaded-virtual warnings. (Closed)
Patch Set: Fixed errors and reverted video capture changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 { 9 {
10 'includes': [ '../build/common.gypi', ], 10 'includes': [ '../build/common.gypi', ],
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 'sctp/sctpdataengine.h', 87 'sctp/sctpdataengine.h',
88 ], 88 ],
89 # TODO(kjellander): Make the code compile without disabling these flags. 89 # TODO(kjellander): Make the code compile without disabling these flags.
90 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307 90 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=3307
91 'cflags': [ 91 'cflags': [
92 '-Wno-deprecated-declarations', 92 '-Wno-deprecated-declarations',
93 ], 93 ],
94 'cflags!': [ 94 'cflags!': [
95 '-Wextra', 95 '-Wextra',
96 ], 96 ],
97 'cflags_cc!': [
98 '-Woverloaded-virtual',
99 ],
100 'msvs_disabled_warnings': [ 97 'msvs_disabled_warnings': [
101 4245, # conversion from 'int' to 'size_t', signed/unsigned mismatch. 98 4245, # conversion from 'int' to 'size_t', signed/unsigned mismatch.
102 4267, # conversion from 'size_t' to 'int', possible loss of data. 99 4267, # conversion from 'size_t' to 'int', possible loss of data.
103 4389, # signed/unsigned mismatch. 100 4389, # signed/unsigned mismatch.
104 ], 101 ],
105 'conditions': [ 102 'conditions': [
106 ['build_libyuv==1', { 103 ['build_libyuv==1', {
107 'dependencies': ['<(DEPTH)/third_party/libyuv/libyuv.gyp:libyuv',], 104 'dependencies': ['<(DEPTH)/third_party/libyuv/libyuv.gyp:libyuv',],
108 }], 105 }],
109 ['build_usrsctp==1', { 106 ['build_usrsctp==1', {
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 'devices/gtkvideorenderer.h', 143 'devices/gtkvideorenderer.h',
147 ], 144 ],
148 'cflags': [ 145 'cflags': [
149 '<!@(pkg-config --cflags gobject-2.0 gthread-2.0 gtk+-2.0)', 146 '<!@(pkg-config --cflags gobject-2.0 gthread-2.0 gtk+-2.0)',
150 ], 147 ],
151 }], 148 }],
152 ], 149 ],
153 }, # target rtc_media 150 }, # target rtc_media
154 ], # targets. 151 ], # targets.
155 } 152 }
OLDNEW
« no previous file with comments | « webrtc/media/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698