Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2467273002:
Update Visual Studio runtime file copying (Closed)
|
Created:
4 years, 1 month ago by ehmaldonado_webrtc Modified:
4 years, 1 month ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionUpdate Visual Studio runtime file copying
Mirror the chromium changes to this list made in
https://codereview.chromium.org/2450933002/
BUG=chromium:497757
NOTRY=True
Committed: https://crrev.com/809f9771b03b5e59d76cc080a4e73a9e15136559
Cr-Commit-Position: refs/heads/master@{#14924}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove visual_studio_version.gni import. #Messages
Total messages: 17 (8 generated)
Description was changed from ========== Mirror Chromium changes. Mirror the chromium changes to this list made in https://codereview.chromium.org/2450933002/ BUG=chromium:497757 ========== to ========== Mirror Chromium changes. Mirror the chromium changes to this list made in https://codereview.chromium.org/2450933002/ BUG=chromium:497757 ==========
ehmaldonado@webrtc.org changed reviewers: + kjellander@webrtc.org
https://codereview.webrtc.org/2467273002/diff/1/webrtc/base/BUILD.gn File webrtc/base/BUILD.gn (left): https://codereview.webrtc.org/2467273002/diff/1/webrtc/base/BUILD.gn#oldcode18 webrtc/base/BUILD.gn:18: import("//build/config/win/visual_studio_version.gni") You can remove this too, right? https://codereview.webrtc.org/2467273002/diff/1/webrtc/base/BUILD.gn#oldcode218 webrtc/base/BUILD.gn:218: # This is a copy of https://codereview.chromium.org/1783973002. copy of ... followed by https://codereview.chromium.org/2450933002
Description was changed from ========== Mirror Chromium changes. Mirror the chromium changes to this list made in https://codereview.chromium.org/2450933002/ BUG=chromium:497757 ========== to ========== Update Visual Studio runtime file copying Mirror the chromium changes to this list made in https://codereview.chromium.org/2450933002/ BUG=chromium:497757 ==========
On 2016/11/02 13:44:21, kjellander_webrtc wrote: > https://codereview.webrtc.org/2467273002/diff/1/webrtc/base/BUILD.gn > File webrtc/base/BUILD.gn (left): > > https://codereview.webrtc.org/2467273002/diff/1/webrtc/base/BUILD.gn#oldcode18 > webrtc/base/BUILD.gn:18: import("//build/config/win/visual_studio_version.gni") > You can remove this too, right? > > https://codereview.webrtc.org/2467273002/diff/1/webrtc/base/BUILD.gn#oldcode218 > webrtc/base/BUILD.gn:218: # This is a copy of > https://codereview.chromium.org/1783973002. > copy of ... followed by https://codereview.chromium.org/2450933002 I changed the title too.
Patchset #2 (id:20001) has been deleted
On 2016/11/02 13:45:10, kjellander_webrtc wrote: > On 2016/11/02 13:44:21, kjellander_webrtc wrote: > > https://codereview.webrtc.org/2467273002/diff/1/webrtc/base/BUILD.gn > > File webrtc/base/BUILD.gn (left): > > > > https://codereview.webrtc.org/2467273002/diff/1/webrtc/base/BUILD.gn#oldcode18 > > webrtc/base/BUILD.gn:18: > import("//build/config/win/visual_studio_version.gni") > > You can remove this too, right? > > > > > https://codereview.webrtc.org/2467273002/diff/1/webrtc/base/BUILD.gn#oldcode218 > > webrtc/base/BUILD.gn:218: # This is a copy of > > https://codereview.chromium.org/1783973002. > > copy of ... followed by https://codereview.chromium.org/2450933002 > > I changed the title too. PTAL
lgtm don't forget NOTRY=True
On 2016/11/03 17:56:14, kjellander_webrtc wrote: > lgtm > don't forget NOTRY=True (but you might want to do a few more trybots to be sure).
Description was changed from ========== Update Visual Studio runtime file copying Mirror the chromium changes to this list made in https://codereview.chromium.org/2450933002/ BUG=chromium:497757 ========== to ========== Update Visual Studio runtime file copying Mirror the chromium changes to this list made in https://codereview.chromium.org/2450933002/ BUG=chromium:497757 NOTRY=True ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Update Visual Studio runtime file copying Mirror the chromium changes to this list made in https://codereview.chromium.org/2450933002/ BUG=chromium:497757 NOTRY=True ========== to ========== Update Visual Studio runtime file copying Mirror the chromium changes to this list made in https://codereview.chromium.org/2450933002/ BUG=chromium:497757 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Update Visual Studio runtime file copying Mirror the chromium changes to this list made in https://codereview.chromium.org/2450933002/ BUG=chromium:497757 NOTRY=True ========== to ========== Update Visual Studio runtime file copying Mirror the chromium changes to this list made in https://codereview.chromium.org/2450933002/ BUG=chromium:497757 NOTRY=True Committed: https://crrev.com/809f9771b03b5e59d76cc080a4e73a9e15136559 Cr-Commit-Position: refs/heads/master@{#14924} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/809f9771b03b5e59d76cc080a4e73a9e15136559 Cr-Commit-Position: refs/heads/master@{#14924} |
