Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 2466993002: Adding data channel ID to Java binding of DataChannel. (Closed)

Created:
4 years, 1 month ago by Taylor Brandstetter
Modified:
4 years, 1 month ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding data channel ID to Java binding of DataChannel. BUG=webrtc:6106 Committed: https://crrev.com/ee8ad2bb0f968e799a09486ed6ce62901fc638cc Cr-Commit-Position: refs/heads/master@{#14879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M webrtc/api/android/java/src/org/webrtc/DataChannel.java View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/android/jni/peerconnection_jni.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Taylor Brandstetter
PTAL
4 years, 1 month ago (2016-11-01 18:21:39 UTC) #2
AlexG
lgtm
4 years, 1 month ago (2016-11-01 19:51:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2466993002/1
4 years, 1 month ago (2016-11-01 21:38:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 21:59:03 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 21:59:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee8ad2bb0f968e799a09486ed6ce62901fc638cc
Cr-Commit-Position: refs/heads/master@{#14879}

Powered by Google App Engine
This is Rietveld 408576698