Reland of "Separating video settings in VideoQualityTest".

Reland of "Separating video settings in VideoQualityTest".

This was landed in https://codereview.webrtc.org/2314403007/

and reverted in https://codereview.webrtc.org/2463733002/ because an error was found.

BUG=660473, webrtc:6609
Committed: https://crrev.com/626bc952aad16e2b3ac17c1ebd10c69bb04a0713
Cr-Commit-Position: refs/heads/master@{#14848}

[minyue-webrtc, 2016-10-31 10:43:29]

Description was changed from

==========
Revert "fixing"

This reverts commit 06e682ea2a2117b64ec21a7f3dc7fee2db629263.

fixing


Merge branch 'master' into cr660473


Övert "Revert of "Separating video settings in VideoQualityTest". (patchset #4
id:60001 of https://codereview.webrtc.org/2314403007/ )"

This reverts commit 9aa78832f99eb0b76bb4655194fec5c291918187.

BUG=
==========

to

==========
Reland of "Separating video settings in VideoQualityTest".

This was landed in https://codereview.webrtc.org/2314403007/

and reverted in https://codereview.webrtc.org/2463733002/ because an error was
found.

BUG=660473, webrtc:6609
==========

[minyue-webrtc, 2016-10-31 10:43:29]

minyue@webrtc.org changed reviewers:
+ stefan@webrtc.org

[minyue-webrtc, 2016-10-31 10:52:22]

Hi Stefan,

I made an error in an early CL, which is reverted. This fixes it.

Patch set 1 is how the reverted one looked like, patch set 2 contains the fix.
PTAL, thanks!

https://codereview.webrtc.org/2466473002/diff/1/webrtc/video/full_stack.cc
File webrtc/video/full_stack.cc (right):

https://codereview.webrtc.org/2466473002/diff/1/webrtc/video/full_stack.cc#ne...
webrtc/video/full_stack.cc:70: "VP8", 1, 0, 0, true, "", "paris_qcif"};
The error is because the 13th param should go to call.send_side_bwe, it was
mistakenly placed inside .video.

https://codereview.webrtc.org/2466473002/diff/20001/webrtc/video/full_stack.cc
File webrtc/video/full_stack.cc (right):

https://codereview.webrtc.org/2466473002/diff/20001/webrtc/video/full_stack.c...
webrtc/video/full_stack.cc:71: "VP8", 1, 0, 0, false, "", "paris_qcif"};
13th param in the new struct is fec, which was false in original test.

[stefan-webrtc, 2016-10-31 10:53:20]

lgtm

[minyue-webrtc, 2016-10-31 11:21:19]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2016-10-31 11:21:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-31 12:47:04]

Description was changed from

==========
Reland of "Separating video settings in VideoQualityTest".

This was landed in https://codereview.webrtc.org/2314403007/

and reverted in https://codereview.webrtc.org/2463733002/ because an error was
found.

BUG=660473, webrtc:6609
==========

to

==========
Reland of "Separating video settings in VideoQualityTest".

This was landed in https://codereview.webrtc.org/2314403007/

and reverted in https://codereview.webrtc.org/2463733002/ because an error was
found.

BUG=660473, webrtc:6609
==========

[commit-bot: I haz the power, 2016-10-31 12:47:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-31 12:47:14]

Description was changed from

==========
Reland of "Separating video settings in VideoQualityTest".

This was landed in https://codereview.webrtc.org/2314403007/

and reverted in https://codereview.webrtc.org/2463733002/ because an error was
found.

BUG=660473, webrtc:6609
==========

to

==========
Reland of "Separating video settings in VideoQualityTest".

This was landed in https://codereview.webrtc.org/2314403007/

and reverted in https://codereview.webrtc.org/2463733002/ because an error was
found.

BUG=660473, webrtc:6609

Committed: https://crrev.com/626bc952aad16e2b3ac17c1ebd10c69bb04a0713
Cr-Commit-Position: refs/heads/master@{#14848}
==========

[commit-bot: I haz the power, 2016-10-31 12:47:15]

Patchset 2 (id:??) landed as
https://crrev.com/626bc952aad16e2b3ac17c1ebd10c69bb04a0713
Cr-Commit-Position: refs/heads/master@{#14848}