Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2465173003: RTCInboundRTPStreamStats added (re-land) (Closed)

Created:
4 years, 1 month ago by hbos
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCInboundRTPStreamStats[1] added. Not all stats are collected in this CL, this must be addressed before closing the issue. [1] https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict* Re-landed after having to be reverted https://codereview.webrtc.org/2470683002/ due to depending on a CL that was reverted. Now that that has re-landed https://codereview.webrtc.org/2470703002/ this is ready to re-land. BUG=chromium:627816, chromium:657855, chromium:657854 R=hta@webrtc.org TBR=deadbeef@webrtc.org Committed: https://crrev.com/eeafe94f28efb9848b528708334abe300c519795 Cr-Commit-Position: refs/heads/master@{#14868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -21 lines) Patch
M webrtc/api/rtcstatscollector.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/api/rtcstatscollector.cc View 6 chunks +81 lines, -4 lines 0 comments Download
M webrtc/api/rtcstatscollector_unittest.cc View 6 chunks +116 lines, -14 lines 0 comments Download
M webrtc/api/stats/rtcstats_objects.h View 1 chunk +42 lines, -0 lines 0 comments Download
M webrtc/stats/rtcstats_objects.cc View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hbos
Please take a (re-)look, hta.
4 years, 1 month ago (2016-11-01 09:38:29 UTC) #1
hta-webrtc
lgtm
4 years, 1 month ago (2016-11-01 09:40:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2465173003/1
4 years, 1 month ago (2016-11-01 09:40:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 10:00:20 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 10:00:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eeafe94f28efb9848b528708334abe300c519795
Cr-Commit-Position: refs/heads/master@{#14868}

Powered by Google App Engine
This is Rietveld 408576698