Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2464553002: Revert of Add DesktopCapturer GetSourceList SelectSource FocusOnSelectedSource functions (Closed)

Created:
4 years, 1 month ago by Hzj_jie
Modified:
4 years, 1 month ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Jamie
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add DesktopCapturer GetSourceList SelectSource FocusOnSelectedSource functions (patchset #3 id:120001 of https://codereview.chromium.org/2452263003/ ) Reason for revert: Build break in Chromium Original issue's description: > Add DesktopCapturer GetSourceList SelectSource FocusOnSelectedSource functions > > I have chosen part of 2435603010 changes to compose this change. > According to the discussion we have made in previous change, this CL contains, > 1. Source structure to represent a source of a DesktopCapturer. > 2. GetSourceList / SelectSource / FocusOnSelectedSource functions in > DesktopCapturer. > 3. ScreenCapturer and WindowCapturer forward corresponding functions to the new > DesktopCapturer APIs. > > After this change, We can remove WindowCapturer & ScreenCapturer references from > Chromium, and use the new APIs. > > BUG=webrtc:6513 > > Committed: https://crrev.com/9cb0b3b4ac916cdf52d97a63d923dfbe73f0541e > Cr-Commit-Position: refs/heads/master@{#14830} TBR=sergeyu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6513 Committed: https://crrev.com/fcab7d62d56fd3cb6c43c9f9354d6a6d1db1126c Cr-Commit-Position: refs/heads/master@{#14831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -218 lines) Patch
M webrtc/modules/desktop_capture/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_capture.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/desktop_capturer.h View 5 chunks +3 lines, -38 lines 0 comments Download
D webrtc/modules/desktop_capture/desktop_capturer.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer.h View 2 chunks +3 lines, -10 lines 0 comments Download
D webrtc/modules/desktop_capture/screen_capturer.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer.h View 2 chunks +6 lines, -14 lines 0 comments Download
D webrtc/modules/desktop_capture/window_capturer.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Hzj_jie
Created Revert of Add DesktopCapturer GetSourceList SelectSource FocusOnSelectedSource functions
4 years, 1 month ago (2016-10-29 00:14:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2464553002/1
4 years, 1 month ago (2016-10-29 00:14:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-29 00:14:12 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-29 00:14:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcab7d62d56fd3cb6c43c9f9354d6a6d1db1126c
Cr-Commit-Position: refs/heads/master@{#14831}

Powered by Google App Engine
This is Rietveld 408576698