Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Side by Side Diff: webrtc/base/sequenced_task_checker_impl.h

Issue 2464383002: Use queue label as id in SequencedTaskChecker when not running on TaskQueue (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_BASE_SEQUENCED_TASK_CHECKER_IMPL_H_ 11 #ifndef WEBRTC_BASE_SEQUENCED_TASK_CHECKER_IMPL_H_
12 #define WEBRTC_BASE_SEQUENCED_TASK_CHECKER_IMPL_H_ 12 #define WEBRTC_BASE_SEQUENCED_TASK_CHECKER_IMPL_H_
13 13
14 #include "webrtc/base/thread_checker.h" 14 #include "webrtc/base/thread_checker.h"
15 15
16 namespace rtc { 16 namespace rtc {
17 17
18 class TaskQueue; 18 class TaskQueue;
19 // Real implementation of SequencedTaskChecker, for use in debug mode, or 19 // Real implementation of SequencedTaskChecker, for use in debug mode, or
20 // for temporary use in release mode. 20 // for temporary use in release mode.
21 // 21 //
22 // Note: You should almost always use the SequencedTaskChecker class to get the 22 // Note: You should almost always use the SequencedTaskChecker class to get the
23 // right version for your build configuration. 23 // right version for your build configuration.
24 class SequencedTaskCheckerImpl { 24 class SequencedTaskCheckerImpl {
25 public: 25 public:
26 typedef const void* QueueId;
tommi 2016/11/02 16:32:50 can we make this private?
kthelgason 2016/11/02 16:53:55 Done.
27
26 SequencedTaskCheckerImpl(); 28 SequencedTaskCheckerImpl();
27 ~SequencedTaskCheckerImpl(); 29 ~SequencedTaskCheckerImpl();
28 30
29 bool CalledSequentially() const; 31 bool CalledSequentially() const;
30 32
31 // Changes the task queue or thread that is checked for in IsCurrent. This 33 // Changes the task queue or thread that is checked for in IsCurrent. This
32 // may be useful when an object may be created on one task queue / thread and 34 // may be useful when an object may be created on one task queue / thread and
33 // then used exclusively on another thread. 35 // then used exclusively on another thread.
34 void Detach(); 36 void Detach();
35 37
36 private: 38 private:
37 CriticalSection lock_; 39 CriticalSection lock_;
38 ThreadChecker thread_checker_; 40 ThreadChecker thread_checker_;
39 mutable bool attached_; 41 mutable bool attached_;
40 mutable TaskQueue* valid_queue_; 42 mutable QueueId valid_queue_;
41 }; 43 };
42 44
43 } // namespace rtc 45 } // namespace rtc
44 #endif // WEBRTC_BASE_SEQUENCED_TASK_CHECKER_IMPL_H_ 46 #endif // WEBRTC_BASE_SEQUENCED_TASK_CHECKER_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/base/sequenced_task_checker_impl.cc » ('j') | webrtc/base/sequenced_task_checker_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698