Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java

Issue 2464243002: Add Datachannel support to Android AppRTCMobile (Closed)
Patch Set: data channel patch set 4 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2014 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 private String keyprefDisableBuiltInAgc; 74 private String keyprefDisableBuiltInAgc;
75 private String keyprefDisableBuiltInNs; 75 private String keyprefDisableBuiltInNs;
76 private String keyprefEnableLevelControl; 76 private String keyprefEnableLevelControl;
77 private String keyprefDisplayHud; 77 private String keyprefDisplayHud;
78 private String keyprefTracing; 78 private String keyprefTracing;
79 private String keyprefRoomServerUrl; 79 private String keyprefRoomServerUrl;
80 private String keyprefRoom; 80 private String keyprefRoom;
81 private String keyprefRoomList; 81 private String keyprefRoomList;
82 private ArrayList<String> roomList; 82 private ArrayList<String> roomList;
83 private ArrayAdapter<String> adapter; 83 private ArrayAdapter<String> adapter;
84 private String keyprefEnableDataChannel;
85 private String keyprefOrdered;
86 private String keyprefMaxRetransmitTimeMs;
87 private String keyprefMaxRetransmits;
88 private String keyprefDataProtocol;
89 private String keyprefNegotiated;
90 private String keyprefDataId;
84 91
85 @Override 92 @Override
86 public void onCreate(Bundle savedInstanceState) { 93 public void onCreate(Bundle savedInstanceState) {
87 super.onCreate(savedInstanceState); 94 super.onCreate(savedInstanceState);
88 95
89 // Get setting keys. 96 // Get setting keys.
90 PreferenceManager.setDefaultValues(this, R.xml.preferences, false); 97 PreferenceManager.setDefaultValues(this, R.xml.preferences, false);
91 sharedPref = PreferenceManager.getDefaultSharedPreferences(this); 98 sharedPref = PreferenceManager.getDefaultSharedPreferences(this);
92 keyprefVideoCallEnabled = getString(R.string.pref_videocall_key); 99 keyprefVideoCallEnabled = getString(R.string.pref_videocall_key);
93 keyprefCamera2 = getString(R.string.pref_camera2_key); 100 keyprefCamera2 = getString(R.string.pref_camera2_key);
(...skipping 13 matching lines...) Expand all
107 keyprefOpenSLES = getString(R.string.pref_opensles_key); 114 keyprefOpenSLES = getString(R.string.pref_opensles_key);
108 keyprefDisableBuiltInAec = getString(R.string.pref_disable_built_in_aec_key) ; 115 keyprefDisableBuiltInAec = getString(R.string.pref_disable_built_in_aec_key) ;
109 keyprefDisableBuiltInAgc = getString(R.string.pref_disable_built_in_agc_key) ; 116 keyprefDisableBuiltInAgc = getString(R.string.pref_disable_built_in_agc_key) ;
110 keyprefDisableBuiltInNs = getString(R.string.pref_disable_built_in_ns_key); 117 keyprefDisableBuiltInNs = getString(R.string.pref_disable_built_in_ns_key);
111 keyprefEnableLevelControl = getString(R.string.pref_enable_level_control_key ); 118 keyprefEnableLevelControl = getString(R.string.pref_enable_level_control_key );
112 keyprefDisplayHud = getString(R.string.pref_displayhud_key); 119 keyprefDisplayHud = getString(R.string.pref_displayhud_key);
113 keyprefTracing = getString(R.string.pref_tracing_key); 120 keyprefTracing = getString(R.string.pref_tracing_key);
114 keyprefRoomServerUrl = getString(R.string.pref_room_server_url_key); 121 keyprefRoomServerUrl = getString(R.string.pref_room_server_url_key);
115 keyprefRoom = getString(R.string.pref_room_key); 122 keyprefRoom = getString(R.string.pref_room_key);
116 keyprefRoomList = getString(R.string.pref_room_list_key); 123 keyprefRoomList = getString(R.string.pref_room_list_key);
124 keyprefEnableDataChannel = getString(R.string.pref_enable_datachannel_key);
125 keyprefOrdered = getString(R.string.pref_ordered_key);
126 keyprefMaxRetransmitTimeMs = getString(R.string.pref_max_retransmit_time_ms_ key);
127 keyprefMaxRetransmits = getString(R.string.pref_max_retransmits_key);
128 keyprefDataProtocol = getString(R.string.pref_data_protocol_key);
129 keyprefNegotiated = getString(R.string.pref_negotiated_key);
130 keyprefDataId = getString(R.string.pref_data_id_key);
117 131
118 setContentView(R.layout.activity_connect); 132 setContentView(R.layout.activity_connect);
119 133
120 roomEditText = (EditText) findViewById(R.id.room_edittext); 134 roomEditText = (EditText) findViewById(R.id.room_edittext);
121 roomEditText.setOnEditorActionListener(new TextView.OnEditorActionListener() { 135 roomEditText.setOnEditorActionListener(new TextView.OnEditorActionListener() {
122 @Override 136 @Override
123 public boolean onEditorAction(TextView textView, int i, KeyEvent keyEvent) { 137 public boolean onEditorAction(TextView textView, int i, KeyEvent keyEvent) {
124 if (i == EditorInfo.IME_ACTION_DONE) { 138 if (i == EditorInfo.IME_ACTION_DONE) {
125 addFavoriteButton.performClick(); 139 addFavoriteButton.performClick();
126 return true; 140 return true;
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 } 436 }
423 } 437 }
424 438
425 // Check statistics display option. 439 // Check statistics display option.
426 boolean displayHud = sharedPrefGetBoolean(R.string.pref_displayhud_key, 440 boolean displayHud = sharedPrefGetBoolean(R.string.pref_displayhud_key,
427 CallActivity.EXTRA_DISPLAY_HUD, R.string.pref_displayhud_default, useVal uesFromIntent); 441 CallActivity.EXTRA_DISPLAY_HUD, R.string.pref_displayhud_default, useVal uesFromIntent);
428 442
429 boolean tracing = sharedPrefGetBoolean(R.string.pref_tracing_key, CallActivi ty.EXTRA_TRACING, 443 boolean tracing = sharedPrefGetBoolean(R.string.pref_tracing_key, CallActivi ty.EXTRA_TRACING,
430 R.string.pref_tracing_default, useValuesFromIntent); 444 R.string.pref_tracing_default, useValuesFromIntent);
431 445
446 // Get datachannel options
447 boolean dataChannelEnabled = sharedPrefGetBoolean(R.string.pref_enable_datac hannel_key,
448 CallActivity.EXTRA_DATA_CHANNEL_ENABLED, R.string.pref_enable_datachanne l_default,
449 useValuesFromIntent);
450 boolean ordered = sharedPrefGetBoolean(R.string.pref_ordered_key, CallActivi ty.EXTRA_ORDERED,
451 R.string.pref_ordered_default, useValuesFromIntent);
452 boolean negotiated = sharedPrefGetBoolean(R.string.pref_negotiated_key,
453 CallActivity.EXTRA_NEGOTIATED, R.string.pref_negotiated_default, useValu esFromIntent);
454 int maxRetrMs = Integer.parseInt(sharedPrefGetString(R.string.pref_max_retra nsmit_time_ms_key,
455 CallActivity.EXTRA_MAX_RETRANSMITS_MS, R.string.pref_max_retransmit_time _ms_default,
456 useValuesFromIntent));
457 int maxRetr = Integer.parseInt(
sakal 2016/11/10 14:23:07 I would like a new method sharedPrefGetInteger ins
hekra01 2016/11/10 17:01:21 Done.
458 sharedPrefGetString(R.string.pref_max_retransmits_key, CallActivity.EXTR A_MAX_RETRANSMITS,
459 R.string.pref_max_retransmits_default, useValuesFromIntent));
460 int id = Integer.parseInt(sharedPrefGetString(R.string.pref_data_id_key, Cal lActivity.EXTRA_ID,
461 R.string.pref_data_id_default, useValuesFromIntent));
462 String protocol = sharedPrefGetString(R.string.pref_data_protocol_key,
463 CallActivity.EXTRA_PROTOCOL, R.string.pref_data_protocol_default, useVal uesFromIntent);
464
432 // Start AppRTCMobile activity. 465 // Start AppRTCMobile activity.
433 Log.d(TAG, "Connecting to room " + roomId + " at URL " + roomUrl); 466 Log.d(TAG, "Connecting to room " + roomId + " at URL " + roomUrl);
434 if (validateUrl(roomUrl)) { 467 if (validateUrl(roomUrl)) {
435 Uri uri = Uri.parse(roomUrl); 468 Uri uri = Uri.parse(roomUrl);
436 Intent intent = new Intent(this, CallActivity.class); 469 Intent intent = new Intent(this, CallActivity.class);
437 intent.setData(uri); 470 intent.setData(uri);
438 intent.putExtra(CallActivity.EXTRA_ROOMID, roomId); 471 intent.putExtra(CallActivity.EXTRA_ROOMID, roomId);
439 intent.putExtra(CallActivity.EXTRA_LOOPBACK, loopback); 472 intent.putExtra(CallActivity.EXTRA_LOOPBACK, loopback);
440 intent.putExtra(CallActivity.EXTRA_VIDEO_CALL, videoCallEnabled); 473 intent.putExtra(CallActivity.EXTRA_VIDEO_CALL, videoCallEnabled);
441 intent.putExtra(CallActivity.EXTRA_CAMERA2, useCamera2); 474 intent.putExtra(CallActivity.EXTRA_CAMERA2, useCamera2);
(...skipping 12 matching lines...) Expand all
454 intent.putExtra(CallActivity.EXTRA_DISABLE_BUILT_IN_AGC, disableBuiltInAGC ); 487 intent.putExtra(CallActivity.EXTRA_DISABLE_BUILT_IN_AGC, disableBuiltInAGC );
455 intent.putExtra(CallActivity.EXTRA_DISABLE_BUILT_IN_NS, disableBuiltInNS); 488 intent.putExtra(CallActivity.EXTRA_DISABLE_BUILT_IN_NS, disableBuiltInNS);
456 intent.putExtra(CallActivity.EXTRA_ENABLE_LEVEL_CONTROL, enableLevelContro l); 489 intent.putExtra(CallActivity.EXTRA_ENABLE_LEVEL_CONTROL, enableLevelContro l);
457 intent.putExtra(CallActivity.EXTRA_AUDIO_BITRATE, audioStartBitrate); 490 intent.putExtra(CallActivity.EXTRA_AUDIO_BITRATE, audioStartBitrate);
458 intent.putExtra(CallActivity.EXTRA_AUDIOCODEC, audioCodec); 491 intent.putExtra(CallActivity.EXTRA_AUDIOCODEC, audioCodec);
459 intent.putExtra(CallActivity.EXTRA_DISPLAY_HUD, displayHud); 492 intent.putExtra(CallActivity.EXTRA_DISPLAY_HUD, displayHud);
460 intent.putExtra(CallActivity.EXTRA_TRACING, tracing); 493 intent.putExtra(CallActivity.EXTRA_TRACING, tracing);
461 intent.putExtra(CallActivity.EXTRA_CMDLINE, commandLineRun); 494 intent.putExtra(CallActivity.EXTRA_CMDLINE, commandLineRun);
462 intent.putExtra(CallActivity.EXTRA_RUNTIME, runTimeMs); 495 intent.putExtra(CallActivity.EXTRA_RUNTIME, runTimeMs);
463 496
497 intent.putExtra(CallActivity.EXTRA_DATA_CHANNEL_ENABLED, dataChannelEnable d);
498
499 if (dataChannelEnabled) {
500 intent.putExtra(CallActivity.EXTRA_ORDERED, ordered);
501 intent.putExtra(CallActivity.EXTRA_MAX_RETRANSMITS_MS, maxRetrMs);
502 intent.putExtra(CallActivity.EXTRA_MAX_RETRANSMITS, maxRetr);
503 intent.putExtra(CallActivity.EXTRA_PROTOCOL, protocol);
504 intent.putExtra(CallActivity.EXTRA_NEGOTIATED, negotiated);
505 intent.putExtra(CallActivity.EXTRA_ID, id);
506 }
507
464 if (useValuesFromIntent) { 508 if (useValuesFromIntent) {
465 if (getIntent().hasExtra(CallActivity.EXTRA_VIDEO_FILE_AS_CAMERA)) { 509 if (getIntent().hasExtra(CallActivity.EXTRA_VIDEO_FILE_AS_CAMERA)) {
466 String videoFileAsCamera = 510 String videoFileAsCamera =
467 getIntent().getStringExtra(CallActivity.EXTRA_VIDEO_FILE_AS_CAMERA ); 511 getIntent().getStringExtra(CallActivity.EXTRA_VIDEO_FILE_AS_CAMERA );
468 intent.putExtra(CallActivity.EXTRA_VIDEO_FILE_AS_CAMERA, videoFileAsCa mera); 512 intent.putExtra(CallActivity.EXTRA_VIDEO_FILE_AS_CAMERA, videoFileAsCa mera);
469 } 513 }
470 514
471 if (getIntent().hasExtra(CallActivity.EXTRA_SAVE_REMOTE_VIDEO_TO_FILE)) { 515 if (getIntent().hasExtra(CallActivity.EXTRA_SAVE_REMOTE_VIDEO_TO_FILE)) {
472 String saveRemoteVideoToFile = 516 String saveRemoteVideoToFile =
473 getIntent().getStringExtra(CallActivity.EXTRA_SAVE_REMOTE_VIDEO_TO _FILE); 517 getIntent().getStringExtra(CallActivity.EXTRA_SAVE_REMOTE_VIDEO_TO _FILE);
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 } 575 }
532 }; 576 };
533 577
534 private final OnClickListener connectListener = new OnClickListener() { 578 private final OnClickListener connectListener = new OnClickListener() {
535 @Override 579 @Override
536 public void onClick(View view) { 580 public void onClick(View view) {
537 connectToRoom(roomEditText.getText().toString(), false, false, false, 0); 581 connectToRoom(roomEditText.getText().toString(), false, false, false, 0);
538 } 582 }
539 }; 583 };
540 } 584 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698