Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2463623002: Setting PATH so that the 'plistbuddy' utility can be found, in a typical OS X environment (Closed)

Created:
4 years, 1 month ago by VladimirTechMan
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Setting PATH so that the 'plistbuddy' utility can be found, in a typical OS X environment Restoring a line from the older version (GYP-days) of the build_ios_libs.sh script: modifying PATH so that the PlistBuddy utility can be successfully found and called, as it normally is not available under the PATH directories in a typical OS X environment (even on developer configs). NOTRY=True BUG=webrtc:6372 Committed: https://crrev.com/18b8774792bb53175e0e6b3b31996cb0edfd8a85 Cr-Commit-Position: refs/heads/master@{#14834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/build/ios/build_ios_libs.sh View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
VladimirTechMan
Just restoring a line from the older version (GYP-days) of the build_ios_libs.sh script: Modifying PATH ...
4 years, 1 month ago (2016-10-30 01:48:15 UTC) #4
kjellander_webrtc
lgtm
4 years, 1 month ago (2016-10-31 06:06:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2463623002/1
4 years, 1 month ago (2016-10-31 06:06:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 06:09:47 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 06:09:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18b8774792bb53175e0e6b3b31996cb0edfd8a85
Cr-Commit-Position: refs/heads/master@{#14834}

Powered by Google App Engine
This is Rietveld 408576698