Use rtcp class instead of RTCPUtility parser for rtcp_sender_unittest

Use rtcp::Bye instead of RTCPUtility parser for rtcp_sender_unittest

BUG=webrtc:5565
Committed: https://crrev.com/b1ed609901a937241debd2f05c458e7edcbe5439
Cr-Commit-Position: refs/heads/master@{#14876}

[danilchap, 2016-11-01 10:28:26]

Description was changed from

==========
Use rtcp classes instead of RTCPUtility parser for rtcp_sender_unittest

BUG=webrtc:5565
==========

to

==========
Use rtcp::Bye instead of RTCPUtility parser for rtcp_sender_unittest

BUG=webrtc:5565
==========

[danilchap, 2016-11-01 10:29:36]

danilchap@webrtc.org changed reviewers:
+ sprang@webrtc.org

[sprang_webrtc, 2016-11-01 11:44:06]

https://codereview.webrtc.org/2463343002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc (right):

https://codereview.webrtc.org/2463343002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc:800: << "Bye packet
should be last in a compound RTCP packet.";
Not a fault of this cl, but isn't this a bit backwards? If there is no bye
packet this will succeed. Shouldn't it be

if (packet_end - next_packet == 0) {
  EXPECT_EQ(rtcp::Bye::kPacketType, packet.type());
}

[sprang_webrtc, 2016-11-01 11:46:19]

https://codereview.webrtc.org/2463343002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc (right):

https://codereview.webrtc.org/2463343002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc:800: << "Bye packet
should be last in a compound RTCP packet.";
On 2016/11/01 11:44:05, språng wrote:
> Not a fault of this cl, but isn't this a bit backwards? If there is no bye
> packet this will succeed. Shouldn't it be
> 
> if (packet_end - next_packet == 0) {
>   EXPECT_EQ(rtcp::Bye::kPacketType, packet.type());
> }

...or even

if (packet_end - next_packet == 0) {
  EXPECT_EQ(rtcp::Bye::kPacketType, packet.type());
} else { 
  EXPECT_NE(rtcp::Bye::kPacketType, packet.type());
}

[danilchap, 2016-11-01 12:12:09]

https://codereview.webrtc.org/2463343002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc (right):

https://codereview.webrtc.org/2463343002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc:800: << "Bye packet
should be last in a compound RTCP packet.";
On 2016/11/01 11:46:18, språng wrote:
> On 2016/11/01 11:44:05, språng wrote:
> > Not a fault of this cl, but isn't this a bit backwards? If there is no bye
> > packet this will succeed. Shouldn't it be
> > 
> > if (packet_end - next_packet == 0) {
> >   EXPECT_EQ(rtcp::Bye::kPacketType, packet.type());
> > }
> 
> ...or even
> 
> if (packet_end - next_packet == 0) {
>   EXPECT_EQ(rtcp::Bye::kPacketType, packet.type());
> } else { 
>   EXPECT_NE(rtcp::Bye::kPacketType, packet.type());
> } 

This test is technically correct: it validates that if Bye packet is present, it
is the very last of a Compound packet.
Absent of Bye packet is valid in general.

Though for this particular test absent of Bye packet mean test setup is
incorrect.
Added an additional validation that last packet is Bye packet.
Added comments to note two neighbor similar expectations are actually very
different.

[sprang_webrtc, 2016-11-01 12:23:14]

lgtm
thanks!

[danilchap, 2016-11-01 12:31:23]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-11-01 12:31:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-01 13:38:40]

Description was changed from

==========
Use rtcp::Bye instead of RTCPUtility parser for rtcp_sender_unittest

BUG=webrtc:5565
==========

to

==========
Use rtcp::Bye instead of RTCPUtility parser for rtcp_sender_unittest

BUG=webrtc:5565
==========

[commit-bot: I haz the power, 2016-11-01 13:38:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-01 13:38:45]

Description was changed from

==========
Use rtcp::Bye instead of RTCPUtility parser for rtcp_sender_unittest

BUG=webrtc:5565
==========

to

==========
Use rtcp::Bye instead of RTCPUtility parser for rtcp_sender_unittest

BUG=webrtc:5565

Committed: https://crrev.com/b1ed609901a937241debd2f05c458e7edcbe5439
Cr-Commit-Position: refs/heads/master@{#14876}
==========

[commit-bot: I haz the power, 2016-11-01 13:38:46]

Patchset 2 (id:??) landed as
https://crrev.com/b1ed609901a937241debd2f05c458e7edcbe5439
Cr-Commit-Position: refs/heads/master@{#14876}