Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm

Issue 2463313002: Add a webrtc{en,de}coderfactory implementation for VideoToolbox (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm b/webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm
index 9f24aec11daf611a1a90825d50b772f2580ef552..b4764e3242219796ab21167a97629b1ef8eaf560 100644
--- a/webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm
+++ b/webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm
@@ -21,6 +21,8 @@
#import "RTCVideoTrack+Private.h"
#import "WebRTC/RTCLogging.h"
+#include "videotoolboxvideocodecfactory.h"
+
@implementation RTCPeerConnectionFactory {
std::unique_ptr<rtc::Thread> _networkThread;
std::unique_ptr<rtc::Thread> _workerThread;
@@ -44,9 +46,12 @@
result = _signalingThread->Start();
NSAssert(result, @"Failed to start signaling thread.");
+ const auto encoder_factory = new webrtc::VideoToolboxVideoEncoderFactory();
magjed_webrtc 2016/11/01 14:00:20 nit: Maybe this would be slightly more clear: std
kthelgason 2016/11/01 15:14:30 I think that's a lot of typing to no specific purp
+ const auto decoder_factory = new webrtc::VideoToolboxVideoDecoderFactory();
+
_nativeFactory = webrtc::CreatePeerConnectionFactory(
_networkThread.get(), _workerThread.get(), _signalingThread.get(),
- nullptr, nullptr, nullptr);
+ nullptr, encoder_factory, decoder_factory);
NSAssert(_nativeFactory, @"Failed to initialize PeerConnectionFactory!");
}
return self;

Powered by Google App Engine
This is Rietveld 408576698