Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2463033002:
vp8_impl.cc: Adjust cpu speed setting for arm for devices with 4 or more cores. (Closed)
|
Created:
4 years, 1 month ago by åsapersson Modified:
4 years, 1 month ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
Descriptionvp8_impl.cc: Adjust cpu speed setting for arm for devices with 4 or more cores.
CIF or less: -12 -> -8
VGA: -12 -> -10
BUG=webrtc:6634
Committed: https://crrev.com/384e731455aab122ba717360a3b3db1f4910f243
Cr-Commit-Position: refs/heads/master@{#14873}
Patch Set 1 #
Total comments: 5
Patch Set 2 : address comment #
Messages
Total messages: 18 (10 generated)
Description was changed from ========== vp8_impl.cc: Adjust cpu speed setting (-12 -> -10) for arm for devices with 4 or more cores. BUG=webrtc::6634 ========== to ========== vp8_impl.cc: Adjust cpu speed setting (-12 -> -10) for arm for devices with 4 or more cores. BUG=webrtc:6634 ==========
asapersson@webrtc.org changed reviewers: + glaznev@webrtc.org, marpan@webrtc.org
lgtm https://codereview.webrtc.org/2463033002/diff/1/webrtc/modules/video_coding/c... File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/2463033002/diff/1/webrtc/modules/video_coding/c... webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:575: return (number_of_cores_ >= 4 && width * height <= 352 * 288) ? -10 : -12; May be use -10 for VGA as well? For 352 x 288 use -8 for 4 cores?
marpan@google.com changed reviewers: + marpan@google.com
https://codereview.webrtc.org/2463033002/diff/1/webrtc/modules/video_coding/c... File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/2463033002/diff/1/webrtc/modules/video_coding/c... webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:575: return (number_of_cores_ >= 4 && width * height <= 352 * 288) ? -10 : -12; On 2016/10/31 19:15:31, AlexG wrote: > May be use -10 for VGA as well? For 352 x 288 use -8 for 4 cores? Agree to use -8 for low resolutions and -10 otherwise, for >=4 cores.
https://codereview.webrtc.org/2463033002/diff/1/webrtc/modules/video_coding/c... File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/2463033002/diff/1/webrtc/modules/video_coding/c... webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:575: return (number_of_cores_ >= 4 && width * height <= 352 * 288) ? -10 : -12; On 2016/10/31 19:15:31, AlexG wrote: > May be use -10 for VGA as well? For 352 x 288 use -8 for 4 cores? Done. https://codereview.webrtc.org/2463033002/diff/1/webrtc/modules/video_coding/c... webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:575: return (number_of_cores_ >= 4 && width * height <= 352 * 288) ? -10 : -12; On 2016/10/31 20:07:54, marpan wrote: > On 2016/10/31 19:15:31, AlexG wrote: > > May be use -10 for VGA as well? For 352 x 288 use -8 for 4 cores? > > Agree to use -8 for low resolutions and -10 otherwise, for >=4 cores. Did you mean -10 for > VGA?
https://codereview.webrtc.org/2463033002/diff/1/webrtc/modules/video_coding/c... File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/2463033002/diff/1/webrtc/modules/video_coding/c... webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:575: return (number_of_cores_ >= 4 && width * height <= 352 * 288) ? -10 : -12; On 2016/10/31 21:56:38, åsapersson wrote: > On 2016/10/31 20:07:54, marpan wrote: > > On 2016/10/31 19:15:31, AlexG wrote: > > > May be use -10 for VGA as well? For 352 x 288 use -8 for 4 cores? > > > > Agree to use -8 for low resolutions and -10 otherwise, for >=4 cores. > > Did you mean -10 for > VGA? sorry i meant -10 for VGA
lgtm
Description was changed from ========== vp8_impl.cc: Adjust cpu speed setting (-12 -> -10) for arm for devices with 4 or more cores. BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Adjust cpu speed setting for arm for devices with 4 or more cores. VGA: -12 -> -10 CIF or less: -12 -> -8 BUG=webrtc:6634 ==========
Description was changed from ========== vp8_impl.cc: Adjust cpu speed setting for arm for devices with 4 or more cores. VGA: -12 -> -10 CIF or less: -12 -> -8 BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Adjust cpu speed setting for arm for devices with 4 or more cores. CIF or less: -12 -> -8 VGA or less: -12 -> -10 BUG=webrtc:6634 ==========
Description was changed from ========== vp8_impl.cc: Adjust cpu speed setting for arm for devices with 4 or more cores. CIF or less: -12 -> -8 VGA or less: -12 -> -10 BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Adjust cpu speed setting for arm for devices with 4 or more cores. CIF or less: -12 -> -8 VGA: -12 -> -10 BUG=webrtc:6634 ==========
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org Link to the patchset: https://codereview.webrtc.org/2463033002/#ps20001 (title: "address comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== vp8_impl.cc: Adjust cpu speed setting for arm for devices with 4 or more cores. CIF or less: -12 -> -8 VGA: -12 -> -10 BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Adjust cpu speed setting for arm for devices with 4 or more cores. CIF or less: -12 -> -8 VGA: -12 -> -10 BUG=webrtc:6634 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== vp8_impl.cc: Adjust cpu speed setting for arm for devices with 4 or more cores. CIF or less: -12 -> -8 VGA: -12 -> -10 BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Adjust cpu speed setting for arm for devices with 4 or more cores. CIF or less: -12 -> -8 VGA: -12 -> -10 BUG=webrtc:6634 Committed: https://crrev.com/384e731455aab122ba717360a3b3db1f4910f243 Cr-Commit-Position: refs/heads/master@{#14873} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/384e731455aab122ba717360a3b3db1f4910f243 Cr-Commit-Position: refs/heads/master@{#14873} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
