Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2462663002: Ensure one does not register same rtp header extension with different id (Closed)

Created:
4 years, 1 month ago by danilchap
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ensure one does not register same rtp header extension with different id Added assert to RtpHeaderExtensionMap Altered tests that did. BUG=webrtc:1994 Committed: https://crrev.com/42ca68ab7264154e16291c99f1de7338abc56af7 Cr-Commit-Position: refs/heads/master@{#14840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_header_extension.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
danilchap
4 years, 1 month ago (2016-10-28 15:13:12 UTC) #3
stefan-webrtc
lgtm
4 years, 1 month ago (2016-10-31 09:20:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2462663002/1
4 years, 1 month ago (2016-10-31 09:28:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 10:34:43 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 10:34:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42ca68ab7264154e16291c99f1de7338abc56af7
Cr-Commit-Position: refs/heads/master@{#14840}

Powered by Google App Engine
This is Rietveld 408576698