Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: webrtc/examples/objc/AppRTCMobile/ios/ARDMediaConstraintsModel+Private.h

Issue 2462623002: Add setting to AppRTCMobile for iOS, that can change capture resolution. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/examples/objc/AppRTCMobile/ios/ARDMediaConstraintsModel+Private.h
diff --git a/webrtc/base/logging_mac.mm b/webrtc/examples/objc/AppRTCMobile/ios/ARDMediaConstraintsModel+Private.h
similarity index 56%
copy from webrtc/base/logging_mac.mm
copy to webrtc/examples/objc/AppRTCMobile/ios/ARDMediaConstraintsModel+Private.h
index ffee3541a48245e0179670ce2b013f957bc6b88a..57d507b8142f0595ee217e3f3a363cfdcefbce35 100644
--- a/webrtc/base/logging_mac.mm
+++ b/webrtc/examples/objc/AppRTCMobile/ios/ARDMediaConstraintsModel+Private.h
@@ -8,15 +8,15 @@
* be found in the AUTHORS file in the root of the source tree.
*/
-#include "webrtc/base/logging.h"
-
#import <Foundation/Foundation.h>
+#import "ARDMediaConstraintsModel.h"
+@class ARDMediaConstraintsSettingsStore;
-namespace rtc {
-std::string DescriptionFromOSStatus(OSStatus err) {
- NSError* error =
- [NSError errorWithDomain:NSOSStatusErrorDomain code:err userInfo:nil];
- return error.description.UTF8String;
-}
-} // namespace rtc
+NS_ASSUME_NONNULL_BEGIN
+@interface ARDMediaConstraintsModel ()
+- (ARDMediaConstraintsSettingsStore *)settingsStore;
+- (nullable NSString *)currentVideoResolutionWidthFromStore;
magjed_webrtc 2016/10/31 19:26:39 What's the benefit of having this as a string and
daniela-webrtc 2016/11/01 09:51:12 I've explained the rationale in one of my previous
+- (nullable NSString *)currentVideoResolutionHeightFromStore;
+@end
+NS_ASSUME_NONNULL_END

Powered by Google App Engine
This is Rietveld 408576698