Refactor: Move RTCStatsCollector helper functions to anonymous namespace

Move RTCStatsCollector helper functions to anonymous namespace.

Simple refactoring.
Moved ProduceCertificateStatsFromSSLCertificateStats_s and
ProduceIceCandidateStats_s from member section of RTCStatsCollector
to the anonymous namespace of rtcstatscollector.cc.
The thread check is removed as a result, which makes sense because
the helper function does not know about which thread its input
parameter lives on, that is up to the calling place (which has a thread
check already).

This makes rtcstatscollector.h cleaner, and all ProduceBlahStats
functions are starting points of collecting various stats. (Call all
of them and you get a complete set of stats.)

(Not moving PrepareTransportCertificateStats_s because it is using a
private struct of RTCStatsCollector.)

BUG=627816
Committed: https://crrev.com/02ba211a9f29c8ab605e9924f2a5f098a9052dbc
Cr-Commit-Position: refs/heads/master@{#14818}

[hbos, 2016-10-28 10:50:47]

Patchset #1 (id:1) has been deleted

[hbos, 2016-10-28 11:17:36]

Description was changed from

==========
Refactor: Move RTCStatsCollector helper function to anonymous namespace.

Moved ProduceCertificateStatsFromSSLCertificateStats_s from a member
function to a helper function in the anonymous namespace of
rtcstatscollector.cc.

BUG=
==========

to

==========
Move RTCStatsCollector helper functions to anonymous namespace.

Simple refactoring.
Moved ProduceCertificateStatsFromSSLCertificateStats_s and
ProduceIceCandidateStats_s from member section of RTCStatsCollector
to the anonymous namespace of rtcstatscollector.cc.
The thread check is removed as a result, which makes sense because
the helper function does not know about which thread its input
parameter lives on, that is up to the calling place (which has a thread
check already).

(Not moving PrepareTransportCertificateStats_s because it is using a
private struct of RTCStatsCollector.)

BUG=627816
==========

[hbos, 2016-10-28 11:20:28]

Description was changed from

==========
Move RTCStatsCollector helper functions to anonymous namespace.

Simple refactoring.
Moved ProduceCertificateStatsFromSSLCertificateStats_s and
ProduceIceCandidateStats_s from member section of RTCStatsCollector
to the anonymous namespace of rtcstatscollector.cc.
The thread check is removed as a result, which makes sense because
the helper function does not know about which thread its input
parameter lives on, that is up to the calling place (which has a thread
check already).

(Not moving PrepareTransportCertificateStats_s because it is using a
private struct of RTCStatsCollector.)

BUG=627816
==========

to

==========
Move RTCStatsCollector helper functions to anonymous namespace.

Simple refactoring.
Moved ProduceCertificateStatsFromSSLCertificateStats_s and
ProduceIceCandidateStats_s from member section of RTCStatsCollector
to the anonymous namespace of rtcstatscollector.cc.
The thread check is removed as a result, which makes sense because
the helper function does not know about which thread its input
parameter lives on, that is up to the calling place (which has a thread
check already).

This makes rtcstatscollector.h cleaner, and all ProduceBlahStats
functions are starting points of collecting various stats. (Call all
of them and you get a complete set of stats.)

(Not moving PrepareTransportCertificateStats_s because it is using a
private struct of RTCStatsCollector.)

BUG=627816
==========

[hbos, 2016-10-28 11:20:28]

hbos@webrtc.org changed reviewers:
+ hta@webrtc.org

[hbos, 2016-10-28 11:20:51]

Please take a look, hta.

[hta-webrtc, 2016-10-28 11:27:33]

lgtm

This is a Good Thing.

WRT the one that needs the private member - can you pass it in an extra
parameter or something?

https://codereview.webrtc.org/2462573002/diff/20001/webrtc/api/rtcstatscollec...
File webrtc/api/rtcstatscollector.cc (right):

https://codereview.webrtc.org/2462573002/diff/20001/webrtc/api/rtcstatscollec...
webrtc/api/rtcstatscollector.cc:273: if (kvp.second.local) {
Did I really let you get away with naming a local variable "kvp"....?

[hbos, 2016-10-28 11:41:02]

https://codereview.webrtc.org/2462573002/diff/20001/webrtc/api/rtcstatscollec...
File webrtc/api/rtcstatscollector.cc (right):

https://codereview.webrtc.org/2462573002/diff/20001/webrtc/api/rtcstatscollec...
webrtc/api/rtcstatscollector.cc:273: if (kvp.second.local) {
On 2016/10/28 11:27:33, hta-webrtc wrote:
> Did I really let you get away with naming a local variable "kvp"....?

Yes :D Bwahaha. Okay, renamed.

[hbos, 2016-10-28 11:41:24]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-10-28 11:41:25]

The patchset sent to the CQ was uploaded after l-g-t-m from hta@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2462573002/#ps40001 (title:
"Renamed kvp transport_cert_stats_pair")

[commit-bot: I haz the power, 2016-10-28 11:41:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-28 12:14:56]

Description was changed from

==========
Move RTCStatsCollector helper functions to anonymous namespace.

Simple refactoring.
Moved ProduceCertificateStatsFromSSLCertificateStats_s and
ProduceIceCandidateStats_s from member section of RTCStatsCollector
to the anonymous namespace of rtcstatscollector.cc.
The thread check is removed as a result, which makes sense because
the helper function does not know about which thread its input
parameter lives on, that is up to the calling place (which has a thread
check already).

This makes rtcstatscollector.h cleaner, and all ProduceBlahStats
functions are starting points of collecting various stats. (Call all
of them and you get a complete set of stats.)

(Not moving PrepareTransportCertificateStats_s because it is using a
private struct of RTCStatsCollector.)

BUG=627816
==========

to

==========
Move RTCStatsCollector helper functions to anonymous namespace.

Simple refactoring.
Moved ProduceCertificateStatsFromSSLCertificateStats_s and
ProduceIceCandidateStats_s from member section of RTCStatsCollector
to the anonymous namespace of rtcstatscollector.cc.
The thread check is removed as a result, which makes sense because
the helper function does not know about which thread its input
parameter lives on, that is up to the calling place (which has a thread
check already).

This makes rtcstatscollector.h cleaner, and all ProduceBlahStats
functions are starting points of collecting various stats. (Call all
of them and you get a complete set of stats.)

(Not moving PrepareTransportCertificateStats_s because it is using a
private struct of RTCStatsCollector.)

BUG=627816
==========

[commit-bot: I haz the power, 2016-10-28 12:14:56]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-28 12:15:05]

Description was changed from

==========
Move RTCStatsCollector helper functions to anonymous namespace.

Simple refactoring.
Moved ProduceCertificateStatsFromSSLCertificateStats_s and
ProduceIceCandidateStats_s from member section of RTCStatsCollector
to the anonymous namespace of rtcstatscollector.cc.
The thread check is removed as a result, which makes sense because
the helper function does not know about which thread its input
parameter lives on, that is up to the calling place (which has a thread
check already).

This makes rtcstatscollector.h cleaner, and all ProduceBlahStats
functions are starting points of collecting various stats. (Call all
of them and you get a complete set of stats.)

(Not moving PrepareTransportCertificateStats_s because it is using a
private struct of RTCStatsCollector.)

BUG=627816
==========

to

==========
Move RTCStatsCollector helper functions to anonymous namespace.

Simple refactoring.
Moved ProduceCertificateStatsFromSSLCertificateStats_s and
ProduceIceCandidateStats_s from member section of RTCStatsCollector
to the anonymous namespace of rtcstatscollector.cc.
The thread check is removed as a result, which makes sense because
the helper function does not know about which thread its input
parameter lives on, that is up to the calling place (which has a thread
check already).

This makes rtcstatscollector.h cleaner, and all ProduceBlahStats
functions are starting points of collecting various stats. (Call all
of them and you get a complete set of stats.)

(Not moving PrepareTransportCertificateStats_s because it is using a
private struct of RTCStatsCollector.)

BUG=627816

Committed: https://crrev.com/02ba211a9f29c8ab605e9924f2a5f098a9052dbc
Cr-Commit-Position: refs/heads/master@{#14818}
==========

[commit-bot: I haz the power, 2016-10-28 12:15:06]

Patchset 2 (id:??) landed as
https://crrev.com/02ba211a9f29c8ab605e9924f2a5f098a9052dbc
Cr-Commit-Position: refs/heads/master@{#14818}