Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 2460793002: Delete videorendererfactory.h and cricket::GdiVideoRenderer. (Closed)

Created:
4 years, 1 month ago by nisse-webrtc
Modified:
4 years, 1 month ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete videorendererfactory.h and cricket::GdiVideoRenderer. Ultimately, all of webrtc/media/devices should be deleted, since it is unused in webrtc and has no unit tests. But for the time being we need to keep cricket::GtkVideoRenderer since there are a few applications depending on it. BUG=webrtc:5924 Committed: https://crrev.com/a144be384fcd4efd013f779ec7ed075edc3b903b Cr-Commit-Position: refs/heads/master@{#14835}

Patch Set 1 #

Patch Set 2 : Drop windows link dependencies on d3d9.lib, gdi32.lib and strmiids.lib. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -378 lines) Patch
M webrtc/media/BUILD.gn View 1 2 chunks +0 lines, -12 lines 0 comments Download
D webrtc/media/devices/gdivideorenderer.h View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/media/devices/gdivideorenderer.cc View 1 chunk +0 lines, -260 lines 0 comments Download
D webrtc/media/devices/videorendererfactory.h View 1 chunk +0 lines, -43 lines 0 comments Download
M webrtc/media/media.gyp View 1 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nisse-webrtc
PTAL. In particular, look at the dropped windows link dependencies in the build files. I ...
4 years, 1 month ago (2016-10-28 08:10:04 UTC) #2
pthatcher1
lgtm
4 years, 1 month ago (2016-10-28 19:56:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2460793002/20001
4 years, 1 month ago (2016-10-31 07:31:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 07:59:50 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 07:59:58 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a144be384fcd4efd013f779ec7ed075edc3b903b
Cr-Commit-Position: refs/heads/master@{#14835}

Powered by Google App Engine
This is Rietveld 408576698