Simplify {,Set}UlpfecConfig interface.

webrtc/modules/rtp_rtcp/source/rtp_sender_video.h

Index: webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h b/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
index 60fbb68caea65628066271bdc5c13419203ae41a..eef37af78860d0f6263c461fafc047bf2caf777e 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender_video.h
@@ -58,14 +58,9 @@ class RTPSenderVideo {
 
   void SetVideoCodecType(RtpVideoCodecTypes type);
 
-  // FEC
-  void SetUlpfecConfig(bool enabled,
-                       int red_payload_type,
-                       int ulpfec_payload_type);
-
-  void UlpfecConfig(bool* enabled,
-                    int* red_payload_type,
-                    int* ulpfec_payload_type) const;
+  // ULPFEC.
+  void SetUlpfecConfig(int red_payload_type, int ulpfec_payload_type);
+  void UlpfecConfig(int* red_payload_type, int* ulpfec_payload_type) const;
 
   void SetFecParameters(const FecProtectionParams* delta_params,
                         const FecProtectionParams* key_params);
@@ -94,9 +89,11 @@ class RTPSenderVideo {
   int32_t retransmission_settings_ GUARDED_BY(crit_) = kRetransmitBaseLayer;
 
   // FEC
-  bool fec_enabled_ GUARDED_BY(crit_) = false;
+  bool red_enabled_ GUARDED_BY(crit_) = false;

[danilchap, 2016/10/27 11:53:40]

why do you want red_enabled_ and fec_enabled_ members?
thay can be simple accessors instead if you want that logic centralized:
bool red_enabled() const { return red_payload_type >= 0; }

[brandtr, 2016/10/28 07:46:31]

Yep, this makes sense!

These variables are currently under locks, so I'm adding the member functions as
"heavy" (i.e. CamelCase) non-inline functions.

   int red_payload_type_ GUARDED_BY(crit_) = -1;
+  bool fec_enabled_ GUARDED_BY(crit_) = false;
   int fec_payload_type_ GUARDED_BY(crit_) = -1;
+
   FecProtectionParams delta_fec_params_ GUARDED_BY(crit_) = FecProtectionParams{
       0, 1, kFecMaskRandom};
   FecProtectionParams key_fec_params_ GUARDED_BY(crit_) = FecProtectionParams{