Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 2460533002: Simplify {,Set}UlpfecConfig interface. (Closed)
Patch Set: git cl format. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 // indication. 446 // indication.
447 // This API shall be called before transmision of an RTP packet to ensure 447 // This API shall be called before transmision of an RTP packet to ensure
448 // that the |level| part of the extended RTP header is updated. 448 // that the |level| part of the extended RTP header is updated.
449 // return -1 on failure else 0. 449 // return -1 on failure else 0.
450 virtual int32_t SetAudioLevel(uint8_t level_dbov) = 0; 450 virtual int32_t SetAudioLevel(uint8_t level_dbov) = 0;
451 451
452 // ************************************************************************** 452 // **************************************************************************
453 // Video 453 // Video
454 // ************************************************************************** 454 // **************************************************************************
455 455
456 // Turn on/off ULPFEC. 456 // Set RED and ULPFEC payload types. A payload type of -1 means that the
457 virtual void SetUlpfecConfig(bool enabled, 457 // corresponding feature is turned off. Note that we DO NOT support enabling
458 int red_payload_type, 458 // ULPFEC without enabling RED. However, we DO support enabling RED without
459 // enabling ULPFEC. This is due to an RED/RTX workaround, where the receiver
460 // assumes that RTX packets carry RED if RED has been configured in the SDP,
461 // regardless of what RTX payload type mapping was negotiated in the SDP.
462 // TODO(brandtr): Update this comment when we have removed the RED/RTX
463 // send-side workaround, i.e., when we do not support enabling RED without
464 // enabling ULPFEC.
465 virtual void SetUlpfecConfig(int red_payload_type,
459 int ulpfec_payload_type) = 0; 466 int ulpfec_payload_type) = 0;
460 467
461 virtual int32_t SetFecParameters(const FecProtectionParams* delta_params, 468 virtual int32_t SetFecParameters(const FecProtectionParams* delta_params,
462 const FecProtectionParams* key_params) = 0; 469 const FecProtectionParams* key_params) = 0;
463 470
464 // Set method for requestion a new key frame. 471 // Set method for requestion a new key frame.
465 // Returns -1 on failure else 0. 472 // Returns -1 on failure else 0.
466 virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0; 473 virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0;
467 474
468 // Sends a request for a keyframe. 475 // Sends a request for a keyframe.
469 // Returns -1 on failure else 0. 476 // Returns -1 on failure else 0.
470 virtual int32_t RequestKeyFrame() = 0; 477 virtual int32_t RequestKeyFrame() = 0;
471 }; 478 };
472 479
473 } // namespace webrtc 480 } // namespace webrtc
474 481
475 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_ 482 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698