Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2460463002: Restore symbol level for Android builds. (Closed)

Created:
4 years, 1 month ago by kjellander_webrtc
Modified:
4 years, 1 month ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Restore symbol level for Android builds. With https://codereview.webrtc.org/2447263003/ landed the assert that fired due to large APKs in Chromium is now disabled (it doesn't affect WebRTC builds since we don't have that large APKs). See https://crbug.com/648948 for more info. BUG=webrtc:6596 NOTRY=True Committed: https://crrev.com/5e49c2f09ec47e6c2a9c79cd2861c718567d2468 Cr-Commit-Position: refs/heads/master@{#14796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M webrtc/build/mb_config.pyl View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_webrtc
4 years, 1 month ago (2016-10-27 06:02:54 UTC) #2
ehmaldonado_webrtc
On 2016/10/27 06:02:54, kjellander_webrtc wrote: LGTM
4 years, 1 month ago (2016-10-27 06:54:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2460463002/1
4 years, 1 month ago (2016-10-27 06:58:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 07:00:17 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 07:00:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e49c2f09ec47e6c2a9c79cd2861c718567d2468
Cr-Commit-Position: refs/heads/master@{#14796}

Powered by Google App Engine
This is Rietveld 408576698