webrtc/modules/audio_coding/neteq/rtcp.cc - Issue 2460393002: NetEq jitter calculation now done in int64_t.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/rtcp.cc

Issue 2460393002: NetEq jitter calculation now done in int64_t. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/neteq/rtcp.cc

diff --git a/webrtc/modules/audio_coding/neteq/rtcp.cc b/webrtc/modules/audio_coding/neteq/rtcp.cc

index 7ef40bc814548de74cc86df77a3f4633a76c8f54..c5a7050e8f067143943ef6783252cdb3a566b872 100644

--- a/webrtc/modules/audio_coding/neteq/rtcp.cc

+++ b/webrtc/modules/audio_coding/neteq/rtcp.cc

@@ -47,7 +47,7 @@ void Rtcp::Update(const RTPHeader& rtp_header, uint32_t receive_timestamp) {

if (received_packets_ > 1) {

int32_t ts_diff = receive_timestamp - (rtp_header.timestamp - transit_);

ts_diff = WEBRTC_SPL_ABS_W32(ts_diff);

- int32_t jitter_diff = (ts_diff << 4) - jitter_;

+ uint64_t jitter_diff = (uint64_t{ts_diff} << 4) - jitter_;

ossu 2016/10/31 14:11:01 Uh... I spoke too soon. Clearly this could be nega

// Calculate 15 * jitter_ / 16 + jitter_diff / 16 (with proper rounding).

jitter_ = jitter_ + ((jitter_diff + 8) >> 4);

}

« no previous file with comments | « webrtc/modules/audio_coding/neteq/rtcp.h ('k') | no next file » | no next file with comments »