NetEq jitter calculation now done in int64_t.

NetEq jitter calculation now done in uint64_t.

The timestamps are 32 bit and can (conceivably) be spaced far enough
apart for the calculation, which is done in Q4, to overflow.

BUG=chromium:653268
Committed: https://crrev.com/6b6c88f18428deddf0defdf37fc77a21eef36c47
Cr-Commit-Position: refs/heads/master@{#14856}

[ossu, 2016-10-31 13:38:33]

The CQ bit was checked by ossu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 13:38:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ossu, 2016-10-31 13:42:07]

ossu@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[ossu, 2016-10-31 13:42:07]

I'm not sure what use we'd have of packets with jitter such as this, but the
neteq_rtp_fuzzer is able to generate them.

[commit-bot: I haz the power, 2016-10-31 13:45:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 13:45:51]

Dry run: Try jobs failed on following builders:
  linux_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/19701)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/19664)
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/19124)

[ossu, 2016-10-31 14:11:01]

https://codereview.webrtc.org/2460393002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/rtcp.cc (right):

https://codereview.webrtc.org/2460393002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/rtcp.cc:50: uint64_t jitter_diff =
(uint64_t{ts_diff} << 4) - jitter_;
Uh... I spoke too soon. Clearly this could be negative...

[hlundin-webrtc, 2016-10-31 14:37:47]

lgtm

[ossu, 2016-10-31 14:53:48]

https://codereview.webrtc.org/2460393002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/rtcp.cc (right):

https://codereview.webrtc.org/2460393002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/rtcp.cc:52: RTC_DCHECK_GE(jitter_, 0);
This, really, should be impossible: jitter_diff should never be more negative
than jitter_ is positive, and we're only accumulating one sixteenth of it.

[ossu, 2016-10-31 14:53:53]

The CQ bit was checked by ossu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 14:54:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-31 15:55:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 15:55:21]

Dry run: This issue passed the CQ dry run.

[ossu, 2016-10-31 15:57:40]

The CQ bit was checked by ossu@webrtc.org

[commit-bot: I haz the power, 2016-10-31 15:57:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ossu, 2016-10-31 15:59:26]

The CQ bit was unchecked by ossu@webrtc.org

[commit-bot: I haz the power, 2016-10-31 15:59:29]

Committed patchset #2 (id:20001)

[ossu, 2016-10-31 15:59:41]

Description was changed from

==========
NetEq jitter calculation now done in uint64_t.

The timestamps are 32 bit and can (conceivably) be spaced far enough
apart for the calculation, which is done in Q4, to overflow.

BUG=chromium:653268
==========

to

==========
NetEq jitter calculation now done in int64_t.

The timestamps are 32 bit and can (conceivably) be spaced far enough
apart for the calculation, which is done in Q4, to overflow.

BUG=chromium:653268
==========

[commit-bot: I haz the power, 2016-10-31 16:14:56]

Description was changed from

==========
NetEq jitter calculation now done in int64_t.

The timestamps are 32 bit and can (conceivably) be spaced far enough
apart for the calculation, which is done in Q4, to overflow.

BUG=chromium:653268
==========

to

==========
NetEq jitter calculation now done in uint64_t.

The timestamps are 32 bit and can (conceivably) be spaced far enough
apart for the calculation, which is done in Q4, to overflow.

BUG=chromium:653268

Committed: https://crrev.com/6b6c88f18428deddf0defdf37fc77a21eef36c47
Cr-Commit-Position: refs/heads/master@{#14856}
==========

[commit-bot: I haz the power, 2016-10-31 16:14:57]

Patchset 2 (id:??) landed as
https://crrev.com/6b6c88f18428deddf0defdf37fc77a21eef36c47
Cr-Commit-Position: refs/heads/master@{#14856}