Moving stun_prober target from webrtc/p2p to webrtc/examples

Moving stun_prober target from webrtc/p2p to webrtc/examples

BUG=webrtc:6440
NOTRY=True

Committed: https://crrev.com/aca3a249c35bcab323b8385fae7f260b29a9c71a
Cr-Commit-Position: refs/heads/master@{#14869}

[charujain, 2016-10-31 10:40:34]

Description was changed from

==========
Moving stun_prober target from webrtc/p2p to webrtc/examples

BUG=
==========

to

==========
Moving stun_prober target from webrtc/p2p to webrtc/examples

BUG=webrtc:6440
==========

[charujain, 2016-10-31 10:41:21]

charujain@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2016-10-31 11:47:57]

https://codereview.webrtc.org/2460343002/diff/1/webrtc/examples/BUILD.gn
File webrtc/examples/BUILD.gn (right):

https://codereview.webrtc.org/2460343002/diff/1/webrtc/examples/BUILD.gn#newc...
webrtc/examples/BUILD.gn:552: "main.cc",
Create a stun_prober directory to contain this file. A main.cc directly in tools
is a bit confusing (very unclear what it is).

[kjellander_webrtc, 2016-10-31 13:51:24]

lgtm with nit addressed but you need a webrtc/p2p owner to approve as well.

https://codereview.webrtc.org/2460343002/diff/20001/webrtc/examples/BUILD.gn
File webrtc/examples/BUILD.gn (right):

https://codereview.webrtc.org/2460343002/diff/20001/webrtc/examples/BUILD.gn#...
webrtc/examples/BUILD.gn:35: # TODO(kjellander): Move this to examples or tools.
This should be removed now.

[charujain, 2016-10-31 13:57:05]

charujain@webrtc.org changed reviewers:
+ henrika@webrtc.org

[charujain, 2016-10-31 13:57:34]

On 2016/10/31 13:51:24, kjellander_webrtc wrote:
> lgtm with nit addressed but you need a webrtc/p2p owner to approve as well.
> 
> https://codereview.webrtc.org/2460343002/diff/20001/webrtc/examples/BUILD.gn
> File webrtc/examples/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2460343002/diff/20001/webrtc/examples/BUILD.gn#...
> webrtc/examples/BUILD.gn:35: # TODO(kjellander): Move this to examples or
tools.
> This should be removed now.

Done. 

+henrika@ for owners approval

[henrika_webrtc, 2016-10-31 14:01:04]

I am really not a suitable owner here. Could you check git blame for the
modified files and find someone who has
done work?

[henrika_webrtc, 2016-10-31 14:01:50]

It looks like webrtc/examples/stunprober/main.cc should be excluded from this
CL.

[charujain, 2016-10-31 14:25:08]

charujain@webrtc.org changed reviewers:
+ perkj@webrtc.org
- henrika@webrtc.org

[charujain, 2016-10-31 14:25:09]

+perkj@ for owners approval

[perkj_webrtc, 2016-10-31 17:47:46]

lgtm

[charujain, 2016-11-01 08:49:30]

The CQ bit was checked by charujain@webrtc.org

[charujain, 2016-11-01 08:49:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2460343002/#ps40001 (title:
"Removed todo comment as it is no longer applicable")

[commit-bot: I haz the power, 2016-11-01 08:49:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-01 09:10:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 09:10:46]

Try jobs failed on following builders:
  win_x64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gyp_dbg/builds/...)

[kjellander_webrtc, 2016-11-01 09:12:09]

On 2016/11/01 09:10:46, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_x64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gyp_dbg/builds/...)

Ah, can you make similar GYP changes?

[charujain, 2016-11-01 09:22:22]

On 2016/11/01 09:12:09, kjellander_webrtc wrote:
> On 2016/11/01 09:10:46, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   win_x64_gyp_dbg on master.tryserver.webrtc (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gyp_dbg/builds/...)
> 
> Ah, can you make similar GYP changes?

Done.

[kjellander_webrtc, 2016-11-01 09:41:18]

https://codereview.webrtc.org/2460343002/diff/60001/webrtc/webrtc_examples.gyp
File webrtc/webrtc_examples.gyp (right):

https://codereview.webrtc.org/2460343002/diff/60001/webrtc/webrtc_examples.gy...
webrtc/webrtc_examples.gyp:476: 'stunprober/main.cc',
Change to examples/stunprober/main.cc or trybots will fail.

[charujain, 2016-11-01 09:45:36]

On 2016/11/01 09:41:18, kjellander_webrtc wrote:
> https://codereview.webrtc.org/2460343002/diff/60001/webrtc/webrtc_examples.gyp
> File webrtc/webrtc_examples.gyp (right):
> 
>
https://codereview.webrtc.org/2460343002/diff/60001/webrtc/webrtc_examples.gy...
> webrtc/webrtc_examples.gyp:476: 'stunprober/main.cc',
> Change to examples/stunprober/main.cc or trybots will fail.

Correct, I missed to see this is out side examples/ dir.

[kjellander_webrtc, 2016-11-01 10:03:47]

Seems you somehow made the deps incorrect in PS#5.

https://codereview.webrtc.org/2460343002/diff/80001/webrtc/webrtc_examples.gyp
File webrtc/webrtc_examples.gyp (right):

https://codereview.webrtc.org/2460343002/diff/80001/webrtc/webrtc_examples.gy...
webrtc/webrtc_examples.gyp:472: './p2p:libstunprober',
now this is incorrect. One dot seems to have disappeared.

[kjellander_webrtc, 2016-11-01 10:05:28]

My mistake, this is valid.

lgtm with last comment addressed.
Please submit with NOTRY=True

https://codereview.webrtc.org/2460343002/diff/80001/webrtc/webrtc_examples.gyp
File webrtc/webrtc_examples.gyp (right):

https://codereview.webrtc.org/2460343002/diff/80001/webrtc/webrtc_examples.gy...
webrtc/webrtc_examples.gyp:472: './p2p:libstunprober',
On 2016/11/01 10:03:47, kjellander_webrtc wrote:
> now this is incorrect. One dot seems to have disappeared.

My bad. This file sits at the top level. But please remove the ./ part, e.g:
'p2p:libstunprober',
'p2p:rtc_p2p',

[charujain, 2016-11-01 10:07:23]

Description was changed from

==========
Moving stun_prober target from webrtc/p2p to webrtc/examples

BUG=webrtc:6440
==========

to

==========
Moving stun_prober target from webrtc/p2p to webrtc/examples

BUG=webrtc:6440
NOTRY=True
==========

[charujain, 2016-11-01 10:07:38]

On 2016/11/01 10:05:28, kjellander_webrtc wrote:
> My mistake, this is valid.
> 
> lgtm with last comment addressed.
> Please submit with NOTRY=True
> 
> https://codereview.webrtc.org/2460343002/diff/80001/webrtc/webrtc_examples.gyp
> File webrtc/webrtc_examples.gyp (right):
> 
>
https://codereview.webrtc.org/2460343002/diff/80001/webrtc/webrtc_examples.gy...
> webrtc/webrtc_examples.gyp:472: './p2p:libstunprober',
> On 2016/11/01 10:03:47, kjellander_webrtc wrote:
> > now this is incorrect. One dot seems to have disappeared.
> 
> My bad. This file sits at the top level. But please remove the ./ part, e.g:
> 'p2p:libstunprober',
> 'p2p:rtc_p2p',

Done.

[charujain, 2016-11-01 10:07:52]

The CQ bit was checked by charujain@webrtc.org

[charujain, 2016-11-01 10:07:52]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org,
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2460343002/#ps100001 (title:
"Removed './' from deps path")

[commit-bot: I haz the power, 2016-11-01 10:08:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-01 10:09:16]

Description was changed from

==========
Moving stun_prober target from webrtc/p2p to webrtc/examples

BUG=webrtc:6440
NOTRY=True
==========

to

==========
Moving stun_prober target from webrtc/p2p to webrtc/examples

BUG=webrtc:6440
NOTRY=True
==========

[commit-bot: I haz the power, 2016-11-01 10:09:18]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-01 10:09:26]

Description was changed from

==========
Moving stun_prober target from webrtc/p2p to webrtc/examples

BUG=webrtc:6440
NOTRY=True
==========

to

==========
Moving stun_prober target from webrtc/p2p to webrtc/examples

BUG=webrtc:6440
NOTRY=True

Committed: https://crrev.com/aca3a249c35bcab323b8385fae7f260b29a9c71a
Cr-Commit-Position: refs/heads/master@{#14869}
==========

[commit-bot: I haz the power, 2016-11-01 10:09:27]

Patchset 6 (id:??) landed as
https://crrev.com/aca3a249c35bcab323b8385fae7f260b29a9c71a
Cr-Commit-Position: refs/heads/master@{#14869}